fix: remove unnecessary typing-extensions for py3.8 #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nadobando
added a commit
that referenced
this pull request
Feb 3, 2021
* chore: typo in parser docs Signed-off-by: heitorlessa <lessa@amazon.co.uk> * docs(appconfig): Use correct import for docstring (aws-powertools#271) * docs(appconfig): Use correct import for docstring * docs: Rename variable back * chore: fix immer and socket.io CVEs (aws-powertools#278) * fix: upgrade amplify to fix immer CVE * fix: forcefully upgrade socket.io as gatsby can't be upgraded * fix: remove unnecessary typing-extensions for py3.8 (#3) Co-authored-by: heitorlessa <lessa@amazon.co.uk> Co-authored-by: Michael Brewer <michael.brewer@gyft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue aws-powertools#280
Description of changes:
Added if block to know if typing_extensions should be imported based on the python version.
if python >= 3.8 typing extensions will not be imported and the native implementation will be used
else will try to import typing_extensions and catch the ImportError
Updated modules which imported this dependency.
Checklist
Breaking change checklist
RFC issue #:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.