Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intel Galileo Support for Development Library #38

Merged
merged 2 commits into from
Jan 14, 2015
Merged

Conversation

spaniakos
Copy link
Contributor

just added support for the Development library

TMRh20 added a commit that referenced this pull request Jan 14, 2015
Merge Intel Galileo Support for Development Library #38 from @spaniakos
@TMRh20 TMRh20 merged commit c8a3e85 into nRF24:master Jan 14, 2015
@TMRh20
Copy link
Member

TMRh20 commented Jan 14, 2015

@spaniakos Hmm, it looks like this pushed to master, not development?

@spaniakos
Copy link
Contributor Author

Probabaly i bad pull request . Can u revert the changes and i will make a
new one with development and restore my master branch if i meshed up.
On Jan 14, 2015 9:15 AM, "TMRh20" notifications@github.com wrote:

@spaniakos https://github.com/spaniakos Hmm, it looks like this pushed
to master, not development?


Reply to this email directly or view it on GitHub
#38 (comment).

@TMRh20
Copy link
Member

TMRh20 commented Jan 14, 2015

I just took a closer look at both branches, and I see the commits for Galileo support on both of them, so I think we just had Dev/Master backwards. The changes look good to me otherwise, could you take a look before reverting?

@spaniakos
Copy link
Contributor Author

Sure i will make tests in both , but i need 2 hours to go to my equipment.
On Jan 14, 2015 11:08 AM, "TMRh20" notifications@github.com wrote:

I just took a closer look at both branches, and I see the commits for
Galileo support on both of them, so I think we just had Dev/Master
backwards. The changes look good to me otherwise, could you take a look
before reverting?


Reply to this email directly or view it on GitHub
#38 (comment).

@spaniakos
Copy link
Contributor Author

yep , i see the mistake , initialy i pushed to master. then i reverted back and pushed to Development
but i havent changed the pull request to development branch.
therefore i need to redo the pull request.

you have just accepted a bulk pull request contained nothing but the revised changes for master.

@Bitobux Bitobux mentioned this pull request Feb 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants