-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Arduino CI #166
Merged
Merged
Add Arduino CI #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a CI workflow to compile the examples against AVR and SAMD cores. Also I formatted the examples using AStyle formater (as used in the Arduino IDE). Additionally, I replaced the direct calls to
printf()
withSerial.print*()
(its likely I missed some) in the examples. This also closes #165 by removing the sync.* files per recommendation of @TMRh20Exceptions
I had to skip checking a couple examples:
RF24Network::sleepNode()
&RF24Network::setup_watchdog()
aren't defined for all cores, even though this example does compile for AVR cores (not SAMD core).Also, I didn't add the SpenceKonde ATTinyCore for now. I thought it might be better to work out which platforms/cores would work for the above examples.
About doing a Linux Build CI
My attempts to add a linux build workflow were rather fruitless (see commit titles). The error that I couldn't work out is
when executing
file /usr/local/lib/librf24.so.1.3.11
(because librf24-bcm.so is just a symlink to librf24.so.<latest>), I get the following:the output from the same cmd on my RPi4 is
Notice the "LSB shared object" vs "LSB pie executable"