RF24NetworkFrame.toString() has no definition

[2bndy5]

I think I found another uncompleted relic from development. The RF24Network.h declares a toString() function for RF24NetworkFrame, but there is no definition for it in RF24Network.cpp. There aren't any references to RF24NetworkFrame::toString() in any debug statements (including the ones that are commented out).

I don't think there is a need to have toString() defined for RF24NetworkFrame objects. Furthermore, this is a function that the user could write themselves (in conjunction with RF24NetworkHeader::toString()) if their application wants/needs to. Similar functionality is exhibited in the debug statements.

ps - RF24NetworkHeader::toString() is much more convenient/applicable than having a RF24NetworkFrame::toString().

[TMRh20]

I agree, no need for frame.toString

…

On Aug 10, 2021, at 8:14 PM, Brendan ***@***.***> wrote:  I think I found another uncompleted relic from development. The RF24Network.h declares a toString() function for RF24NetworkFrame, but there is no definition for it in RF24Network.cpp. There aren't any references to RF24NetworkFrame::toString() in any debug statements (including the ones that are commented out). I don't think there is a need to have toString() defined for RF24NetworkFrame objects. Furthermore, this is a function that the user could write themselves (in conjunction with RF24NetworkHeader::toString()) if their application wants/needs to. Similar functionality is exhibited in the debug statements. ps - RF24NetworkHeader::toString() is much more convenient/applicable than having a RF24NetworkFrame::toString(). — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

[2bndy5]

ok I'll remove the RF24NetworkFrame::toString() declaration. This will also remove the accompanied docs that doxygen is currently outputting.