You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I believe the peek functionality that was implemented in pull #106 broke the Python wrapper. From the comments on that pull request, it does not appear that the Python wrapper was tested.
Using the latest from the repo, when building the Python wrapper, I get the following error:
pyRF24Network.cpp: In function ‘void init_module_RF24Network()’:
pyRF24Network.cpp:107:60: error: no matches converting function ‘peek’ to type ‘peek_function_type {aka void (class RF24Network::*)(struct RF24NetworkHeader&)}’
, peek_function_type( &::RF24Network::peek )
^
In file included from pyRF24Network.cpp:3:0:
/usr/local/include/RF24Network/RF24Network.h:445:8: note: candidates are: void RF24Network::peek(RF24NetworkHeader&, void*, uint16_t)
void peek(RF24NetworkHeader& header, void* message, uint16_t maxlen);
^~~~
/usr/local/include/RF24Network/RF24Network.h:432:12: note: uint16_t RF24Network::peek(RF24NetworkHeader&)
uint16_t peek(RF24NetworkHeader& header);
^~~~
error: command 'gcc' failed with exit status 1
I checked out commit a2ce4ae and reinstalled the library. Running ./setup.py build is successful and the module is installed.
After removing the module and checking out commit ce12854 - which is the commit for PR #106, I reinstalled the library. Running ./setup.py build results in the same error message as above.
I'll try my hand at a fix for this, but wanted to open an issue for this in case someone better at boost wants to tackle it.
The text was updated successfully, but these errors were encountered:
cnlangness
added a commit
to cnlangness/RF24Network
that referenced
this issue
Mar 30, 2018
@Avamander I will open a PR once I confirm that there aren't any adverse downstream effects from adding the uint16_t.
I also plan on digging in to the reason that it is required now. I suspect it may be that during compilation before, there was only one option for peek, so there was no confusion. Now that there are multiple options, it may require more specificity.
I believe the peek functionality that was implemented in pull #106 broke the Python wrapper. From the comments on that pull request, it does not appear that the Python wrapper was tested.
Using the latest from the repo, when building the Python wrapper, I get the following error:
I checked out commit a2ce4ae and reinstalled the library. Running
./setup.py build
is successful and the module is installed.After removing the module and checking out commit ce12854 - which is the commit for PR #106, I reinstalled the library. Running
./setup.py build
results in the same error message as above.I'll try my hand at a fix for this, but wanted to open an issue for this in case someone better at boost wants to tackle it.
The text was updated successfully, but these errors were encountered: