✨ Make Microsoft service root configurable for Outlook and OneDrive nodes #13451
+230
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Hey @kyle-blacklist Do you have documentation links for each of the URLs and can you add some tests to verify that the correct URLs are being sent in the request. |
I do and will. I'm also planning on submitting a change to the N8N docs that contains more information about the service root urls. |
This change makes the service root configurable for the Microsoft Outlook nodes. The service root endpoint is configurable in the Outlook credential. The motivation behind this change is to allow the Microsoft Outlook N8N node to connect to the other tenant types such as the Microsoft GovCloud instances.
This change makes the service root configurable for the Microsoft OneDrive nodes. The service root endpoint is configurable in the OneDrive credential. The motivation behind this change is to allow the Microsoft OneDrive N8N node to connect to the other tenant types such as the Microsoft GovCloud instances.
2f281fd to
a2bcd75
Compare
|
@Joffcom I added tests for the new functionality as well as a comment about the source of the service root urls. I also added a change for the docs, but I'm not sure how to sequence the PR's so I haven't opened the one for the docs yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change adds the ability to use the different Microsoft service roots that are available in the Outlook and OneDrive nodes. For example, the Microsoft GovCloud service root can be configured so that
https://graph.microsoft.usis used instead ofhttps://graphql.microsoft.com.Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)