Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Rename NodeView.v2 to NodeView (no-changelog) #13421

Merged
merged 1 commit into from
Feb 21, 2025

Conversation

alexgrozav
Copy link
Member

Summary

Remaining work from NodeView removal.

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/CAT-657/rename-nodeviewv2-to-nodeview

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@alexgrozav alexgrozav self-assigned this Feb 21, 2025
Copy link

codecov bot commented Feb 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

Copy link

cypress bot commented Feb 21, 2025

n8n    Run #9408

Run Properties:  status check passed Passed #9408  •  git commit ab62f82963: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 alexgrozav 🗃️ e2e/*
Project n8n
Branch Review cat-657-rename-nodeviewv2-to-nodeview
Run status status check passed Passed #9408
Run duration 04m 46s
Commit git commit ab62f82963: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 alexgrozav 🗃️ e2e/*
Committer Alex Grozav
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 2
Tests that did not run due to a developer annotating a test with .skip  Pending 5
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 437
View all changes introduced in this branch ↗︎

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Feb 21, 2025
Copy link
Contributor

✅ All Cypress E2E specs passed

@alexgrozav alexgrozav merged commit eb27465 into master Feb 21, 2025
37 checks passed
@alexgrozav alexgrozav deleted the cat-657-rename-nodeviewv2-to-nodeview branch February 21, 2025 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants