feat(core): Add metric for active workflow count #13420
Open
+244
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18c1702 to
583e8c9
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
Adds a new metric for active workflow count. This metric is checked every time metrics are collected. Due to the workflow count being potentially quite high, we also cache the result and utilize the cached value. This metric needs to be enabled separately and the TTL can be configured.
583e8c9 to
71559c1
Compare
ivov
reviewed
Feb 24, 2025
Comment on lines
+60
to
+64
| async getActiveCount() { | ||
| return await this.count({ | ||
| where: { active: true }, | ||
| }); | ||
| } |
There was a problem hiding this comment.
Curious why not get this from memory instead? See ActiveWorkflows.ts
There was a problem hiding this comment.
I wasn't aware this was kept up to date somewhere in memory. I can try it out, would make the implementation simpler.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new metric for active workflow count. This metric is checked every time metrics are collected. Due to the workflow count being potentially quite high, we also cache the result and utilize the cached value.
This metric needs to be enabled separately and the TTL can be configured.
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/CP-1797/add-metric-for-active-workflow-count
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)