Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Do not assign all paired items (no-changelog) #11716

Merged
merged 10 commits into from
Feb 6, 2025

Conversation

michael-radency
Copy link
Contributor

Summary

return undefined if no paired items could be inferred instead of generation from input

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/NODE-1598/paireditem-when-we-dont-have-any-matches-return-paireditem-undefined

@michael-radency michael-radency added n8n team Authored by the n8n team node/issue Issue with a node labels Nov 13, 2024
Copy link
Contributor

@ShireenMissi ShireenMissi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

Copy link
Contributor

github-actions bot commented Feb 6, 2025

✅ All Cypress E2E specs passed

Copy link

cypress bot commented Feb 6, 2025

n8n    Run #9160

Run Properties:  status check passed Passed #9160  •  git commit 631e67f226: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 michael-radency 🗃️ e2e/*
Project n8n
Branch Review node-1598-paireditem-matches-update
Run status status check passed Passed #9160
Run duration 04m 26s
Commit git commit 631e67f226: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 michael-radency 🗃️ e2e/*
Committer Michael Kret
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 5
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 433
View all changes introduced in this branch ↗︎

@ShireenMissi ShireenMissi merged commit 4c2546d into master Feb 6, 2025
37 checks passed
@ShireenMissi ShireenMissi deleted the node-1598-paireditem-matches-update branch February 6, 2025 13:46
@janober
Copy link
Member

janober commented Feb 13, 2025

Got released with n8n@1.79.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team node/issue Issue with a node Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants