fix(GitHub Node): Don't truncate filenames retrieved from GitHub (#12923

)

Co-authored-by: Dana Lee <dana@n8n.io>

packages/core/src/__tests__/node-execute-functions.test.ts

@@ -33,6 +33,7 @@ import {
 	parseContentType,
 	parseIncomingMessage,
 	parseRequestObject,
+	prepareBinaryData,
 	proxyRequestToAxios,
 	removeEmptyBody,
 	setBinaryDataBuffer,
@@ -94,6 +95,27 @@ describe('NodeExecuteFunctions', () => {
 			expect(getBinaryDataBufferResponse).toEqual(inputData);
 		});
 
+		test('test prepareBinaryData parses filenames correctly', async () => {
+			const filenameExpected = [
+				{
+					filename: 't?ext',
+					expected: 't?ext',
+				},
+				{
+					filename: 'no-symbol',
+					expected: 'no-symbol',
+				},
+			];
+
+			for (const { filename, expected } of filenameExpected) {
+				const binaryData: Buffer = Buffer.from('This is some binary data', 'utf8');
+
+				const result = await prepareBinaryData(binaryData, 'workflowId', 'executionId', filename);
+
+				expect(result.fileName).toEqual(expected);
+			}
+		});
+
 		test("test getBinaryDataBuffer(...) & setBinaryDataBuffer(...) methods in 'filesystem' mode", async () => {
 			Container.set(BinaryDataService, new BinaryDataService());
 

packages/core/src/node-execute-functions.ts

@@ -1202,12 +1202,7 @@ export async function prepareBinaryData(
 	};
 
 	if (filePath) {
-		if (filePath.includes('?')) {
-			// Remove maybe present query parameters
-			filePath = filePath.split('?').shift();
-		}
-
-		const filePathParts = path.parse(filePath as string);
+		const filePathParts = path.parse(filePath);
 
 		if (filePathParts.dir !== '') {
 			returnData.directory = filePathParts.dir;