Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dependencies): add tslib as dependency #1499

Merged
merged 2 commits into from
Aug 31, 2022

Conversation

viniciuspalma
Copy link
Contributor

Description

Projects that currently are using yarn Berry with PnP or any strict dependency
resolver, that requires that all dependencies are specified on
package.json otherwise it would endue in an error if not treated correct

Since https://www.typescriptlang.org/tsconfig#importHelpers is currently
being used, tslib should be exported as a dependency to external runners
get the proper import.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Using yarn berry project, install any plugin and try to bundle it via typescript.

Checklist:

  • I have followed the CONTRIBUTING doc and the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Further comments

resolves #1497

Projects that currenlty are using yarn Berry with PnP or any strict dependency
resolver, that requires that all dependecies are speciefied on
package.json otherwise it would endup in a error if not treted correct

Since https://www.typescriptlang.org/tsconfig#importHelpers is currently
being used tslib should be exported as a dependency to external runners
get the proper import.
@changeset-bot
Copy link

changeset-bot bot commented Aug 23, 2022

🦋 Changeset detected

Latest commit: 0942fb1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 34 packages
Name Type
@envelop/core Minor
@envelop/apollo-datasources Major
@envelop/apollo-federation Major
@envelop/apollo-server-errors Major
@envelop/apollo-tracing Major
@envelop/auth0 Major
@envelop/dataloader Major
@envelop/depth-limit Major
@envelop/disable-introspection Major
@envelop/execute-subscription-event Major
@envelop/extended-validation Major
@envelop/filter-operation-type Major
@envelop/fragment-arguments Major
@envelop/generic-auth Major
@envelop/graphql-jit Major
@envelop/graphql-middleware Major
@envelop/graphql-modules Major
@envelop/live-query Major
@envelop/newrelic Major
@envelop/opentelemetry Major
@envelop/operation-field-permissions Major
@envelop/parser-cache Major
@envelop/persisted-operations Major
@envelop/preload-assets Major
@envelop/prometheus Major
@envelop/rate-limiter Major
@envelop/resource-limitations Major
@envelop/response-cache Major
@envelop/response-cache-redis Minor
@envelop/sentry Major
@envelop/statsd Major
@envelop/validation-cache Major
@envelop/testing Major
@envelop/types Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Aug 23, 2022

Someone is attempting to deploy a commit to the The Guild Team on Vercel.

A member of the Team first needs to authorize it.

@ardatan ardatan requested a review from n1ru4l August 30, 2022 20:19
@n1ru4l n1ru4l merged commit 1f7af02 into n1ru4l:main Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Yarn 3.2.2 - tslib missing on dependencies from response-cache-redis
2 participants