feat: Gno resolver

.github/codecov.yml

@@ -10,19 +10,10 @@ coverage:
   round: down
   precision: 2
   status:
-    project:
+    patch: # new lines
       default:
-        target: auto
-        threshold: 5 # Let's decrease this later.
-        base: parent
-        if_no_uploads: error
-        if_not_found: success
-        if_ci_failed: error
-        only_pulls: false
-    patch:
-      default:
-        target: auto
-        threshold: 5 # Let's decrease this later.
+        target: 80
+        threshold: 10
         base: auto
         if_no_uploads: error
         if_not_found: success

.github/workflows/bot.yml

@@ -39,10 +39,12 @@ jobs:
   define-prs-matrix:
     name: Define PRs matrix
     # Skip this workflow if:
+    #   - the bot is not configured on this repo/fork
     #   - the bot is retriggering itself
     #   - the event is emitted by codecov
     #   - the event is a review on a pull request from a fork (see save-pr-number job below)
     if: |
+      vars.GH_BOT_LOGIN != '' &&
       github.actor != vars.GH_BOT_LOGIN &&
       github.actor != 'codecov[bot]' &&
       (github.event_name != 'pull_request_review' || github.event.pull_request.base.repo.full_name == github.event.pull_request.head.repo.full_name)

.github/workflows/examples.yml

@@ -29,7 +29,7 @@ jobs:
         with:
           go-version: ${{ matrix.goversion }}
       - run: go install -v ./gnovm/cmd/gno
-      - run: go run ./gnovm/cmd/gno transpile -v --gobuild ./examples
+      - run: go run ./gnovm/cmd/gno tool transpile -v --gobuild ./examples
   test:
     strategy:
       fail-fast: false

.github/workflows/genesis-verify.yml

@@ -14,7 +14,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        testnet: [ "test5.gno.land" ]
+        testnet: [ ] # Currently, all active testnet deployment genesis.json are legacy
     runs-on: ubuntu-latest
     steps:
       - name: Checkout code

.github/workflows/gh-pages.yml

@@ -1,11 +1,14 @@
 # generate Go docs and publish on gh-pages branch
 # Live at: https://gnolang.github.io/gno
-name: Go Reference Docs Deployment
+name: GitHub pages (godoc & stdlib_diff) build and deploy
 
 on:
   push:
     branches:
       - master
+  pull_request:
+    branches:
+      - master
   workflow_dispatch:
 
 permissions:
@@ -19,29 +22,39 @@ concurrency:
 
 jobs:
   build:
-    if: ${{ github.repository == 'gnolang/gno' }} # Alternatively, validate based on provided tokens and permissions.
+    if: github.repository == 'gnolang/gno' # Alternatively, validate based on provided tokens and permissions.
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
       - uses: actions/setup-go@v5
         with:
           go-version-file: go.mod
-      - run: echo "GOROOT=$(go env GOROOT)" >> $GITHUB_ENV
-      - run: echo $GOROOT
+      # Use the goroot at the top of the project to compare with the GnoVM
+      # stdlib, rather than the one in stdlib_diff (which may have a go.mod with
+      # a different toolchain version).
+      - run: echo "GOROOT_SAVE=$(go env GOROOT)" >> $GITHUB_ENV
       - run: "cd misc/stdlib_diff && make gen"
       - run: "cd misc/gendocs && make install gen"
       - run: "mkdir -p pages_output/stdlib_diff"
       - run: |
           cp -r misc/gendocs/godoc/* pages_output/
           cp -r misc/stdlib_diff/stdlib_diff/* pages_output/stdlib_diff/
+
+      # These two last steps will be skipped on pull requests
       - uses: actions/configure-pages@v5
         id: pages
+        if: github.event_name != 'pull_request'
+
       - uses: actions/upload-pages-artifact@v3
+        if: github.event_name != 'pull_request'
         with:
           path: ./pages_output
 
   deploy:
-    if: ${{ github.repository == 'gnolang/gno' }} # Alternatively, validate based on provided tokens and permissions.
+    if: >
+      github.repository == 'gnolang/gno' &&
+      github.ref == 'refs/heads/master' &&
+      github.event_name == 'push'
     runs-on: ubuntu-latest
     environment:
       name: github-pages

.github/workflows/gnoland.yml

@@ -11,6 +11,12 @@ on:
       # since there are integration suites that cover the gnovm / tm2
       - gnovm/**
       - tm2/**
+      # Changes to examples/ can create failures in gno.land, eg. txtars,
+      # see: https://github.com/gnolang/gno/pull/3590
+      - examples/**
+      # We trigger the testing workflow for changes to the main go.mod,
+      # since this can affect test results
+      - go.mod
   workflow_dispatch:
 
 jobs:

.github/workflows/gnovm.yml

@@ -8,6 +8,9 @@ on:
     paths:
       - gnovm/**
       - tm2/** # GnoVM has a dependency on TM2 types
+      # We trigger the testing workflow for changes to the main go.mod,
+      # since this can affect test results
+      - go.mod
   workflow_dispatch:
 
 jobs:

.github/workflows/releaser-master.yml

@@ -6,6 +6,9 @@ on:
       - master
   workflow_dispatch:
 
+concurrency:
+  group: ${{ github.workflow }}-${{ github.ref || github.run_id }}
+
 permissions:
   contents: write # needed to write releases
   id-token: write # needed for keyless signing
@@ -27,7 +30,7 @@ jobs:
           cache: true
 
       - uses: sigstore/cosign-installer@v3.7.0
-      - uses: anchore/sbom-action/download-syft@v0.17.8
+      - uses: anchore/sbom-action/download-syft@v0.17.9
 
       - uses: docker/login-action@v3
         with:

.github/workflows/releaser-nightly.yml

@@ -24,7 +24,7 @@ jobs:
           cache: true
 
       - uses: sigstore/cosign-installer@v3.7.0
-      - uses: anchore/sbom-action/download-syft@v0.17.8
+      - uses: anchore/sbom-action/download-syft@v0.17.9
 
       - uses: docker/login-action@v3
         with:

.github/workflows/tm2.yml

@@ -7,6 +7,9 @@ on:
   pull_request:
     paths:
       - tm2/**
+      # We trigger the testing workflow for changes to the main go.mod,
+      # since this can affect test results
+      - go.mod
   workflow_dispatch:
 
 jobs:

.gitignore

@@ -34,3 +34,6 @@ coverage.out
 *.swp
 *.swo
 *.bak
+
+.tmp/
+wal/

CONTRIBUTING.md

@@ -198,7 +198,7 @@ Additionally, it's not possible to use `gofumpt` for code formatting with
 
 (flycheck-define-checker gno-lint
   "A GNO syntax checker using the gno lint tool."
-  :command ("gno" "lint" source-original)
+  :command ("gno" "tool" "lint" source-original)
   :error-patterns (;; ./file.gno:32: error message (code=1)
                    (error line-start (file-name) ":" line ": " (message) " (code=" (id (one-or-more digit)) ")." line-end))
   ;; Ensure the file is saved, to work around

contribs/github-bot/Makefile

@@ -0,0 +1,16 @@
+GNOROOT_DIR ?= $(abspath $(lastword $(MAKEFILE_LIST))/../../../)
+
+rundep := go run -modfile ../../misc/devdeps/go.mod
+golangci_lint := $(rundep) github.com/golangci/golangci-lint/cmd/golangci-lint
+
+.PHONY: install
+install:
+	go install .
+
+.PHONY: lint
+lint:
+	$(golangci_lint) --config ../../.github/golangci.yml run ./...
+
+.PHONY: test
+test:
+	go test $(GOTEST_FLAGS) -v ./...

contribs/github-bot/go.mod

@@ -1,8 +1,8 @@
 module github.com/gnolang/gno/contribs/github-bot
 
-go 1.22
+go 1.22.0
 
-toolchain go1.22.2
+toolchain go1.23.2
 
 replace github.com/gnolang/gno => ../..
 
@@ -11,7 +11,7 @@ require (
 	github.com/google/go-github/v64 v64.0.0
 	github.com/migueleliasweb/go-github-mock v1.0.1
 	github.com/sethvargo/go-githubactions v1.3.0
-	github.com/stretchr/testify v1.9.0
+	github.com/stretchr/testify v1.10.0
 	github.com/xlab/treeprint v1.2.0
 )
 
@@ -21,8 +21,8 @@ require (
 	github.com/gorilla/mux v1.8.1 // indirect
 	github.com/peterbourgon/ff/v3 v3.4.0 // indirect
 	github.com/pmezard/go-difflib v1.0.0 // indirect
-	golang.org/x/sys v0.24.0 // indirect
-	golang.org/x/term v0.23.0 // indirect
+	golang.org/x/sys v0.29.0 // indirect
+	golang.org/x/term v0.28.0 // indirect
 	golang.org/x/time v0.3.0 // indirect
 	gopkg.in/yaml.v3 v3.0.1 // indirect
 )

contribs/github-bot/internal/check/comment.tmpl

@@ -27,7 +27,7 @@
 1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.
 
 ##### 📚 Resources:
-- [Report a bug with the bot](https://github.com/gnolang/gno/issues/3238).
+- [Report a bug with the bot](https://www.github.com/gnolang/gno/issues/3238).
 - [View the bot’s configuration file](https://github.com/gnolang/gno/tree/master/contribs/github-bot/internal/config/config.go).
 
 {{ if or .AutoRules .ManualRules }}<details><summary><b>Debug</b></summary><blockquote>

contribs/github-bot/internal/conditions/author.go

@@ -58,3 +58,24 @@ func (a *authorInTeam) IsMet(pr *github.PullRequest, details treeprint.Tree) boo
 func AuthorInTeam(gh *client.GitHub, team string) Condition {
 	return &authorInTeam{gh: gh, team: team}
 }
+
+type authorAssociationIs struct {
+	assoc string
+}
+
+var _ Condition = &authorAssociationIs{}
+
+func (a *authorAssociationIs) IsMet(pr *github.PullRequest, details treeprint.Tree) bool {
+	detail := fmt.Sprintf("Pull request author has author_association: %q", a.assoc)
+
+	return utils.AddStatusNode(pr.GetAuthorAssociation() == a.assoc, detail, details)
+}
+
+// AuthorAssociationIs asserts that the author of the PR has the given value for
+// the GitHub "author association" field, on the PR.
+//
+// See https://docs.github.com/en/graphql/reference/enums#commentauthorassociation
+// for a list of possible values and descriptions.
+func AuthorAssociationIs(association string) Condition {
+	return &authorAssociationIs{assoc: association}
+}

contribs/github-bot/internal/conditions/author_test.go

@@ -91,3 +91,30 @@ func TestAuthorInTeam(t *testing.T) {
 		})
 	}
 }
+
+func TestAuthorAssociationIs(t *testing.T) {
+	t.Parallel()
+
+	for _, testCase := range []struct {
+		name            string
+		association     string
+		associationWant string
+		isMet           bool
+	}{
+		{"has", "MEMBER", "MEMBER", true},
+		{"hasNot", "COLLABORATOR", "MEMBER", false},
+	} {
+		t.Run(testCase.name, func(t *testing.T) {
+			t.Parallel()
+
+			pr := &github.PullRequest{
+				AuthorAssociation: github.String(testCase.association),
+			}
+			details := treeprint.New()
+			condition := AuthorAssociationIs(testCase.associationWant)
+
+			assert.Equal(t, condition.IsMet(pr, details), testCase.isMet, fmt.Sprintf("condition should have a met status: %t", testCase.isMet))
+			assert.True(t, utils.TestLastNodeStatus(t, testCase.isMet, details), fmt.Sprintf("condition details should have a status: %t", testCase.isMet))
+		})
+	}
+}

contribs/github-bot/internal/conditions/draft.go

@@ -10,7 +10,7 @@ import (
 // Draft Condition.
 type draft struct{}
 
-var _ Condition = &baseBranch{}
+var _ Condition = &draft{}
 
 func (*draft) IsMet(pr *github.PullRequest, details treeprint.Tree) bool {
 	return utils.AddStatusNode(pr.GetDraft(), "This pull request is a draft", details)