Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose blob has/status functions #217

Closed
arduano opened this issue Jan 19, 2025 · 1 comment · Fixed by #218
Closed

Expose blob has/status functions #217

arduano opened this issue Jan 19, 2025 · 1 comment · Fixed by #218
Assignees
@dignifiedquire
Labels
feature New feature or request

Comments

@arduano
Copy link

arduano commented Jan 19, 2025

Please expose the following functions:

  • blobs::Client::status
  • blobs::Client::has

I was looking at the JS API and I believe it's missing them. Not sure if the C FFI has them or not.

It's important for clients to know what blobs are already downloaded and which are not, to avoid triggering extra unnecessary downloads, or for gossip-based broadcasting of who has what blob on request.
@dignifiedquire dignifiedquire added the feature New feature or request label Jan 20, 2025
@dignifiedquire dignifiedquire self-assigned this Jan 20, 2025
dignifiedquire added a commit that referenced this issue Jan 20, 2025
@dignifiedquire
feat: add has and status blobs methods
dd44807 
Closes #217
@dignifiedquire dignifiedquire mentioned this issue Jan 20, 2025
Merged
@dignifiedquire
Copy link
Contributor

Added these on all APIs: #218

@n0bot n0bot bot added this to iroh Jan 23, 2025
ramfox pushed a commit that referenced this issue Feb 4, 2025
@dignifiedquire
feat: add has and status blobs methods (#218)
928f690 
Closes #217
@github-project-automation github-project-automation bot moved this to ✅ Done in iroh Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dignifiedquire dignifiedquire

Labels
feature New feature or request
Projects
iroh
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add has and status blobs methods n0-computer/iroh-ffi
2 participants
@dignifiedquire @arduano