Improved support for referrer and URL anchor testing. #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Ruby: get :foo, :anchor => 'bar' In JavaScript: window.location.hash === '#bar'
Tempfiles are deleted when they are garbage collected, so constructing the Harmony::Page from a Tempfile with zero references can cause errors. Now we build the page in the Tempfile's block to avoid any unfortunate problems.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Martin,
I've added a few bits to Holy Grail to help testing scripts that read either the referrer or the URL anchor:
Ability to fake a referrer – if the referrer request header is set in the test (@request.env['HTTP_REFERER']) it will also be set on the Harmony page's document.
Ability to set an anchor in the URL – if the request in the test includes an anchor (e.g. get :foo, :anchor => 'bar' ) then this will be set on the URL given to Harmony so it can be read by the JavaScript.
Better compatibility with TextMate – just a minor change to disable redgreen when running the tests within TextMate.
I think they're useful extensions, but feel free to pick and choose what you think fits into the project.
George