move runs on, remove commented code

mykrupp · Jan 17, 2025 · f4e0831 · f4e0831
1 parent 813d382
commit f4e0831
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 17 deletions.
diff --git a/.github/workflows/generate-and-build.yaml b/.github/workflows/generate-and-build.yaml
@@ -136,21 +136,6 @@ jobs:
           export POST_BUILD_EXE=${{ env.POST_BUILD_EXE }}
           make all -C ${MATTER_EXTN_ROOT}/${{ inputs.board }}/${{ inputs.app }}-${{ inputs.suffix }} -f ${WORKSPACE_PATH}.solution.Makefile -j8
 
-#      - name: Create Directory to Store Artifact
-#        if: ${{ inputs.workflow_name == 'SQA Build' }}
-#        run: |
-#          FOLDER_PATH="sqa-build-binaries/out/${{ inputs.appType }}/${{ inputs.board }}/${{ inputs.technology }}"
-#          mkdir -p $FOLDER_PATH
-#          echo "FOLDER_PATH=$FOLDER_PATH" >> $GITHUB_ENV
-#
-#      - name: Store Artifact in Directory
-#        if: ${{ inputs.workflow_name == 'SQA Build' }}
-#        run: |
-#          FILE_PATH="${{ env.MATTER_EXTN_ROOT }}/${{ inputs.board }}/${{ inputs.app }}-${{ inputs.suffix }}/${{ inputs.app }}-${{ inputs.suffix }}/build/debug/${{ inputs.app }}-${{ inputs.suffix }}.s37"
-#          mv $FILE_PATH ${{ env.FOLDER_PATH }}/
-#          FULL_ARTIFACT_PATH="${{ env.FOLDER_PATH }}/${{ inputs.app }}-${{ inputs.suffix }}.s37"
-#          echo "FULL_ARTIFACT_PATH=$FULL_ARTIFACT_PATH" >> $GITHUB_ENV
-
       - name: Upload SQA Build Artifact
         if: ${{ inputs.workflow_name == 'SQA Build' }}
         uses: actions/upload-artifact@v4

diff --git a/.github/workflows/sqa-build.yaml b/.github/workflows/sqa-build.yaml
@@ -11,6 +11,7 @@ jobs:
   lto:
     # Job triggered either automatically by release_ or main branch, or manual trigger (if needed)
     # if: ${{ github.event_name == 'workflow_run' && (startsWith(github.event.workflow_run.head_branch, 'release_' || github.event.workflow_run.head_branch == 'main')) || github.event_name == 'workflow_dispatch' }}
+    runs-on: ubuntu-latest
     strategy:
       matrix:
         # Every app builds for every board and suffix
@@ -20,12 +21,10 @@ jobs:
         appType: [ lto ]
         family: [ series-2 ]
         addAppComponent: [ ', toolchain_gcc_lto' ]
-    runs-on: ubuntu-latest
     steps:
     - name: Checkout
       uses: actions/checkout@v4
     - name: ${{ matrix.app }}-${{ matrix.suffix }} ${{ matrix.addAppComponent}} ${{ matrix.board }} ${{ matrix.appType }}
-      id: build_binary
       uses: ./.github/workflows/generate-and-build.yaml
       with:
         app: ${{ matrix.app }}