Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vanilla JS answers Updated #7

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Vanilla JS answers Updated #7

wants to merge 6 commits into from

Conversation

imoris11
Copy link

@imoris11 imoris11 commented Jun 2, 2019

  1. Fix naming convention

  2. Added a few more answers

@mykeels
Copy link
Owner

mykeels commented Jun 2, 2019

There's a file called .DS_Store

It should be ignored. Can you add it to gitignore, and remove it from the PR?

I think deleting the file will help with that.

@mykeels
Copy link
Owner

mykeels commented Jun 9, 2019

Cool!

  1. 04-Type-in-reverse should have its Correct and Wrong indicators as the Emoji ✅ and ❌ .

@imoris11
Copy link
Author

Alright, will take a look at this sometime this week. Was kinda busy last week

@mykeels
Copy link
Owner

mykeels commented Jun 16, 2019

Thanks @imoris11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@imoris11 @mykeels