Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(_mapdata): single variable should be at top level under values #287

Merged
merged 3 commits into from
Jan 14, 2021

Conversation

baby-gnu
Copy link
Contributor

There is no more need to check for the map_jinja version.

@baby-gnu baby-gnu requested a review from myii as a code owner January 12, 2021 17:27
There is no more need to check for the `map_jinja` version.
@baby-gnu baby-gnu force-pushed the fix/mapdata-with-single-variable branch from 2e9bc84 to 79e57eb Compare January 12, 2021 17:33
@myii
Copy link
Owner

myii commented Jan 13, 2021

Thanks for this, @baby-gnu. There are around 12 formulas that have been configured with this map.jinja verification feature, so I'll have to run this across them to evaluate the results. I'll let you know once I've done that.

@baby-gnu
Copy link
Contributor Author

There are around 12 formulas that have been configured with this map.jinja verification feature, so I'll have to run this across them to evaluate the results. I'll let you know once I've done that.

Ok, I was wondering how the reference files are updated ;-)

@myii
Copy link
Owner

myii commented Jan 13, 2021

Ok, I was wondering how the reference files are updated ;-)

@baby-gnu Ah, OK. I covered this in one of the working group meetings, so I'll give you the link to the video once I get a chance to look for it.

@myii
Copy link
Owner

myii commented Jan 13, 2021

@baby-gnu This is where the ssf-formula demonstration begins:

That portion of the discussion last a while so you may need to hit the fast-forward button (or watch it using double-speed)!

@myii
Copy link
Owner

myii commented Jan 13, 2021

@baby-gnu Done some brief initial testing and the results look good. I'll be back again when I've tested it across all of the formulas.

myii pushed a commit to myii/dhcpd-formula that referenced this pull request Jan 14, 2021
myii pushed a commit to myii/firewalld-formula that referenced this pull request Jan 14, 2021
myii pushed a commit to myii/openntpd-formula that referenced this pull request Jan 14, 2021
myii pushed a commit to myii/openvpn-formula that referenced this pull request Jan 14, 2021
myii pushed a commit to myii/php-formula that referenced this pull request Jan 14, 2021
myii pushed a commit to myii/powerdns-formula that referenced this pull request Jan 14, 2021
myii pushed a commit to myii/rabbitmq-formula that referenced this pull request Jan 14, 2021
myii pushed a commit to myii/sudoers-formula that referenced this pull request Jan 14, 2021
myii pushed a commit to myii/template-formula that referenced this pull request Jan 14, 2021
myii pushed a commit to myii/tomcat-formula that referenced this pull request Jan 14, 2021
myii pushed a commit to myii/tomcat-formula that referenced this pull request Jan 14, 2021
@myii myii merged commit bafd500 into myii:master Jan 14, 2021
@myii
Copy link
Owner

myii commented Jan 14, 2021

Nice work, thanks @baby-gnu!

@myii
Copy link
Owner

myii commented Jan 14, 2021

🎉 This PR is included in version 1.238.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@myii myii added the released label Jan 14, 2021
@baby-gnu baby-gnu deleted the fix/mapdata-with-single-variable branch January 15, 2021 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants