Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ISSUE-32 #33

Merged
merged 3 commits into from
Nov 27, 2018
Merged

ISSUE-32 #33

merged 3 commits into from
Nov 27, 2018

Conversation

adrenalinkin
Copy link
Contributor

resolve #32

  • Register cronos:dump and cronos:replace in the service container.
  • Added .idea into .gitignore.
  • Little correction for the documentation.

@adrenalinkin
ISSUE-32:
34bbe4b 
- Register `cronos:dump` and `cronos:replace` in the service container.
- Added `.idea` into `.gitignore`.
- Little correction for the documentation.
@adrenalinkin
ISSUE-32:
7d1305d 
- Fixed problem with Symfony 2
nealio82
nealio82 reviewed Nov 26, 2018
View reviewed changes
.gitignore Outdated
@@ -1,3 +1,4 @@
.idea
Copy link

@nealio82 nealio82 Nov 26, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's generally better to keep IDE (and OS)-specific files out of the project's concerns, otherwise you also end up with entries like .DS_Store and nbproject/* added to the repository as people come along with new tools or operating systems.

Personally I use a global ~/.gitignore_global containing just .idea and .DS_Store, which then means those two files are never added to any project I work on. More info here: https://help.github.com/articles/ignoring-files/#create-a-global-gitignore

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nealio82 Thanks for ~/.gitignore_global concept information. I was revert that change.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@adrenalinkin
ISSUE-32:
956be09 
- Removed `.idea` from the `.gitignore` according to the code review.
@scrutinizer-notifier
Copy link

The inspection completed: No new issues

@gavinlove
Copy link
Member

Thank you for this.

@gavinlove gavinlove merged commit 6ad70bf into mybuilder:master Nov 27, 2018
@adrenalinkin
Copy link
Contributor Author

@nealio82 @gavinlove hello again!
Can you create patch version which will include this corrections?

@adrenalinkin adrenalinkin deleted the ISSUE-32 branch December 5, 2018 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nealio82 nealio82 nealio82 left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Commands does not registered in container [SF4]
4 participants
@adrenalinkin @scrutinizer-notifier @gavinlove @nealio82