Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support configuration databaseId. #912

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

nieqiurong
Copy link
Contributor

@hazendaz hazendaz requested a review from kazuki43zoo November 12, 2023 06:04
Copy link
Member

@kazuki43zoo kazuki43zoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nieqiurong Thank you for your contribution!
I will accept your changes, but I added a small comment, so please check it.

@coveralls
Copy link

coveralls commented Nov 19, 2023

Coverage Status

coverage: 97.719% (+0.02%) from 97.703%
when pulling 6f90947 on nieqiurong:support_dataBaseId
into c8826e6 on mybatis:master.

@kazuki43zoo
Copy link
Member

@nieqiurong If you have a time, please modify tests of MybatisPropertiesTest.

If you are busy, I will perform those.

@nieqiurong
Copy link
Contributor Author

@nieqiurong If you have a time, please modify tests of MybatisPropertiesTest.

If you are busy, I will perform those.

Hi i'm done

@kazuki43zoo kazuki43zoo modified the milestone: 3.0.3 Nov 21, 2023
@kazuki43zoo kazuki43zoo merged commit bda974b into mybatis:master Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants