Open CoreConfiguration#applyTo
#813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kazuki43zoo Do you recall why that was not public? |
|
@hazendaz @kazuki43zoo Any progress? |
|
@be-hase Merged. Thanks. |
|
Hi @be-hase , |
|
@kazuki43zoo sorry for late response. OK, thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to open
CoreConfiguration#applyTo.Why
background
My application needs to connect to multiple MySQL instances, so I need to configure multiple datasource/mybatis.
(Because I am sharding MySQL and accessing replica for some queries).
Therefore, I was using mybatis-spring-starter with customize.
(To be more specific, I did not use
MybatisAutoConfiguration, but wrote the equivalent configuration code myself.)Attempting to upgrade mybatis-spring-boot-starter-3.x
CoreConfigurationis new in mybatis-spring-boot-starter-3.x.I tried to modify our code to mimic this method, but the
CoreConfiguration#applyTois NOT public.Currently, we copy&paste
CoreConfiguration#applyToto workaround.What Changes
Open
CoreConfiguration#applyTo.