-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import image assets into public asset directory #35
Comments
Should organize this folder by story submitter type.
|
For first release, I'm doing a single image per category, as decided here: https://mycovidstoryworkspace.slack.com/archives/C01UF760UG6/p1618934969097100 When we start using a random selection from the sets, we'll need to assign an image at story creation time and add an identifier to the database, so that we always use the same image for each story. |
@kapilharesh Are you still able to tackle this? |
@mwickett To be clear, I've added one image per category and implemented showing them in the feed and single-story pages (not yet committed). The multiple images per category and assigning an identifier at story creation, that's to be done post 1.0, I think. Also, there weren't any collections for Concerned Citizen or Other, so I used a couple of the more generic images from the Patients & Family collection. |
Oops this slipped past me. I can have the photos added to the public dir in a bit. @davesteinberg how is your code referencing the images right now? Are you hard coding the file names (and if so what are those names again?) |
@kapilharesh Sorry, no, let's please not add the collections of images until we have the logic in place to use them. I'm just about to open a PR with my big changes, including adding the one-per-category images that they use. |
Sure - fair enough. What I can probably do is open a branch based off master, and keep them there but just not merge it till the time comes. |
This commit addresses #35 and prepares for the eventual support for random image selection to be displayed as the background of a tile, if no image is uploaded by the user.
Files have been temporarily kept in the |
Good idea. Thanks! |
Moving out of milestone. |
Place in select image assets into
/public/img/background
for use as stock images for story tiles.The text was updated successfully, but these errors were encountered: