Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import image assets into public asset directory #35

Open
kapilharesh opened this issue Apr 20, 2021 · 10 comments
Open

Import image assets into public asset directory #35

kapilharesh opened this issue Apr 20, 2021 · 10 comments

Comments

@kapilharesh
Copy link

Place in select image assets into /public/img/background for use as stock images for story tiles.

@mwickett mwickett added this to the launch milestone Apr 20, 2021
@davesteinberg davesteinberg self-assigned this Apr 21, 2021
@davesteinberg
Copy link
Collaborator

For first release, I'm doing a single image per category, as decided here: https://mycovidstoryworkspace.slack.com/archives/C01UF760UG6/p1618934969097100

When we start using a random selection from the sets, we'll need to assign an image at story creation time and add an identifier to the database, so that we always use the same image for each story.

@mwickett mwickett modified the milestones: launch, MVP v2.0 Apr 22, 2021
@mwickett
Copy link
Contributor

@kapilharesh Are you still able to tackle this?

@davesteinberg davesteinberg removed their assignment Apr 22, 2021
@davesteinberg
Copy link
Collaborator

@mwickett To be clear, I've added one image per category and implemented showing them in the feed and single-story pages (not yet committed).

The multiple images per category and assigning an identifier at story creation, that's to be done post 1.0, I think.

Also, there weren't any collections for Concerned Citizen or Other, so I used a couple of the more generic images from the Patients & Family collection.

@kapilharesh
Copy link
Author

Oops this slipped past me. I can have the photos added to the public dir in a bit. @davesteinberg how is your code referencing the images right now? Are you hard coding the file names (and if so what are those names again?)

@davesteinberg
Copy link
Collaborator

@kapilharesh Sorry, no, let's please not add the collections of images until we have the logic in place to use them.

I'm just about to open a PR with my big changes, including adding the one-per-category images that they use.

@kapilharesh
Copy link
Author

Sure - fair enough.

What I can probably do is open a branch based off master, and keep them there but just not merge it till the time comes.

kapilharesh added a commit that referenced this issue Apr 22, 2021
This commit addresses #35 and prepares for the eventual support for random image selection to be displayed as the background of a tile, if no image is uploaded by the user.
@kapilharesh
Copy link
Author

Files have been temporarily kept in the image-upload branch, so whenever you are all ready to merge it should be able to fit into master without much trouble (as it is fully contained in the public directory).

@davesteinberg
Copy link
Collaborator

Good idea. Thanks!

@silent1mezzo
Copy link
Contributor

Moving out of milestone.

@silent1mezzo silent1mezzo removed this from the MVP v2.0 milestone Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants