[Podspec] Fix a typo causing a circular dependency #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Discovered because of a circular dependency in the podspec via CocoaPods/Molinillo#6 Since the root spec is depending on the subspecs, the subspaces also depend on the root spec. Thus a circular dependency issue.
mxcl
added a commit
that referenced
this pull request
Oct 15, 2014
[Podspec] Fix a typo causing a circular dependency
|
Sorry, not sure how I missed this myself. |
|
Do I need to push a new one? |
|
Nope, I'm going to patch all the existing specs in the master repository because they with be incompatible with the upcoming version of CocoaPods otherwise. Thanks for merging. |
|
Thanks for the PR. |
|
Made the changes in CocoaPods/Specs@b3b5179. Would love if you could review before I merge. |
|
Looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered because of a circular dependency in the podspec via CocoaPods/Molinillo#6
Since the root spec is depending on the subspecs, the subspecs also depend on the root spec. Thus a circular dependency issue.