Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Canary #549

Merged
merged 3 commits into from
Feb 25, 2025
+7 −10
Merged

Canary #549

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8e41b19
chore: simplify Radix Themes import checking
Feb 24, 2025
936fd17
chore: unlighthouse scan 3 times for a more accurate result
mwskwong Feb 24, 2025
34b1493
chore: format value
mwskwong Feb 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 4 additions & 10 deletions eslint.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,6 @@ const compat = new FlatCompat({
baseDirectory: import.meta.dirname,
});

const radixThemesRestrictedImportMessage =
'Please use `import { <Component> } from "@radix-ui/themes/components/<component>"`instead, to avoid unnecessary Radix dependencies being bundled to the client bundle, due to Next.js bundling behavior and Radix Themes now imports from `radix-ui` instead of `@radix-ui/<component>`.';

const config = tseslint.config(
eslint.configs.recommended,
tseslint.configs.strictTypeChecked,
Expand Down Expand Up @@ -84,14 +81,11 @@ const config = tseslint.config(
"@typescript-eslint/no-restricted-imports": [
"error",
{
paths: [
{
message: radixThemesRestrictedImportMessage,
name: "@radix-ui/themes",
},
patterns: [
{
message: radixThemesRestrictedImportMessage,
name: "@radix-ui/themes/components/index",
regex: "^@radix-ui/themes(/components/index)?$",
message:
'Please use `import { <Component> } from "@radix-ui/themes/components/<component>"`instead, to avoid unnecessary Radix dependencies being bundled to the client bundle, due to Next.js bundling behavior and Radix Themes now imports from `radix-ui` instead of `@radix-ui/<component>`.',
},
],
},
Expand Down
3 changes: 3 additions & 0 deletions unlighthouse.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,9 @@ const config = {
extraHeaders: {
"x-vercel-protection-bypass": process.env.VERCEL_AUTOMATION_BYPASS_SECRET,
},
scanner: {
samples: 3,
},
lighthouseOptions: {
throttling: {
cpuSlowdownMultiplier: 8.6, // matches GitHub Action Ubuntu performance
Expand Down