Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporary text notebooks are created in the same dir as the original notebook #1222

Merged
merged 1 commit into from
Mar 24, 2024

Conversation

mwouts
Copy link
Owner

@mwouts mwouts commented Mar 24, 2024

when using the --pipe or --check commands

Closes #1206

Copy link

Thank you for making this pull request.

Did you know? You can try it on Binder: Binder:lab or Binder:notebook.

Also, the version of Jupytext developed in this PR can be installed with pip:

pip install git+https://github.com/mwouts/jupytext.git@fix_pytest_notebook

(this requires nodejs, see more at Developing Jupytext)

Copy link

codecov bot commented Mar 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.73%. Comparing base (1ef1dea) to head (fb85a0f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1222   +/-   ##
=======================================
  Coverage   97.73%   97.73%           
=======================================
  Files          29       29           
  Lines        4456     4460    +4     
=======================================
+ Hits         4355     4359    +4     
  Misses        101      101           
Flag Coverage Δ
external 75.14% <60.00%> (-0.03%) ⬇️
functional 88.50% <100.00%> (-0.06%) ⬇️
integration 77.33% <100.00%> (+0.02%) ⬆️
unit 66.55% <60.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

when using the --pipe or --check commands
@mwouts mwouts force-pushed the fix_pytest_notebook branch from fb85a0f to 940fce4 Compare March 24, 2024 21:09
@mwouts mwouts merged commit f33e519 into main Mar 24, 2024
3 checks passed
@mwouts mwouts deleted the fix_pytest_notebook branch March 24, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write temporary notebooks to a TemporaryDirectory rather than NamedTemporaryFile
1 participant