Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unicode path names are not supported #70

Closed
BrunoYang0918 opened this issue Sep 11, 2018 · 12 comments
Closed

Unicode path names are not supported #70

BrunoYang0918 opened this issue Sep 11, 2018 · 12 comments

Comments

@BrunoYang0918
Copy link

All previous steps works fine before saving the data in python format. Jupyter Notebook refuses to open the updated ipython output with the below message:

An unknown error occurred while loading this notebook. This version can load notebook formats v4 or earlier. See the server log for details.

@mwouts
Copy link
Owner

mwouts commented Sep 11, 2018

Thanks Bruno for reporting. Could you please share the server logs (i.e. what was printed in the console where you run jupyter notebook)? Or even the modified python script? Thanks

@BrunoYang0918
Copy link
Author

BrunoYang0918 commented Sep 11, 2018 via email

@mwouts
Copy link
Owner

mwouts commented Sep 11, 2018

Useful details, thanks. Can you change the notebook name so that it only has ASCII characters for now? Does that solve the issue?

@BrunoYang0918
Copy link
Author

BrunoYang0918 commented Sep 11, 2018 via email

@mwouts
Copy link
Owner

mwouts commented Sep 11, 2018

I'm glad you like it! Thanks. Please do not close the issue yet - I will implement one more test, and a bugfix, to be sure that you can use unicode file and path names in the next version.

@mwouts mwouts changed the title Output Jupyter Notebook can not be opened Unicode file or path names are not supported Sep 11, 2018
@mwouts mwouts changed the title Unicode file or path names are not supported Unicode path names are not supported Sep 11, 2018
mwouts added a commit that referenced this issue Sep 11, 2018
mwouts added a commit that referenced this issue Sep 11, 2018
@mwouts mwouts mentioned this issue Sep 11, 2018
@mwouts
Copy link
Owner

mwouts commented Sep 11, 2018

@BrunoYang0918 , could you please upgrade to v0.6.4 and confirm whether you issue is resolved?

pip install jupytext==0.6.4
# + restart jupyter notebook

Thanks

@BrunoYang0918
Copy link
Author

BrunoYang0918 commented Sep 12, 2018 via email

@BrunoYang0918
Copy link
Author

BrunoYang0918 commented Sep 19, 2018 via email

@mwouts
Copy link
Owner

mwouts commented Sep 19, 2018

Great news! Thanks for the feedback.

@mppaskov
Copy link

Not sure if this is related but I had a notebook named 1.Some Notebook.ipynb and it was not exporting automatically to .py. Even after manually exporting the notebook with the command line it would not sync. Was able to fix this by renaming the notebook Some Notebook.ipynb.

@mwouts
Copy link
Owner

mwouts commented Sep 21, 2018

Thanks @mppaskov for reporting. I will add your example as a unit test.

Please let me recall that you cannot expect notebook to export and sync automatically! If you want a notebook to be saved into both extensions, you have to add the "jupytext_formats": "ipynb,py" entry in the metadata (alternatively, a global config is possible, cf. the documentation ).

Also, the command line tool is not going to add that metadata, so it is not enough to create the .py file manually.

I agree that editing the notebook metadata is not very user friendly. At some point we will provide a Jupyter extension (i.e. buttons in the jupyter notebook) to make that easier, see #86.

@mwouts
Copy link
Owner

mwouts commented Sep 21, 2018

@mppaskov , I think I can reproduce your issue. Please follow progresses on that at #87. Thanks for letting me know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants