Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jupytext content manager thinks directories ending in .jl are .jl files #228

Closed
alexmorley opened this issue May 15, 2019 · 2 comments
Closed

Comments

@alexmorley
Copy link

alexmorley commented May 15, 2019

Expected behaviour:
content manager checks that files ending in a particular extension are files not directories.

Actual behaviour:
this isn't checked. Makes it impossible to open the directory in Jupyterlab.

Possible fix:
Presumably there needs to be an extra command to check the filetype in the content manager.

PS. I'll try and have a look to fix next week but just want to check if anyone else has run into this?
PPS. Jupytext is awesome :)

@mwouts
Copy link
Owner

mwouts commented May 15, 2019

Hello @alexmorley , thanks for reporting this! Sure, we'll fix this - I will soon publish a new version with the fix...

mwouts added a commit that referenced this issue May 15, 2019
@mwouts mwouts mentioned this issue May 15, 2019
@mwouts mwouts closed this as completed in e98a526 May 15, 2019
@mwouts
Copy link
Owner

mwouts commented May 15, 2019

This is corrected in version 1.1.2, available now on pip, and tomorrow on conda-forge. Thanks @alexmorley for reporting this !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants