This repository has been archived by the owner on Jul 30, 2023. It is now read-only.
rough & minimal changes to get index.ts to compile #4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with these changes I can successfully compile
index.ts
and thus move topip install -e .
I am no jlab extension expert myself, I just happen to have written my first one a few weeks ago (on jlab4 too), and it had to do with metadata a lot, so I thought I could help out a bit with that
note that this is the only scope for this PR:
hope this helps
PS. see also e.g.
https://www.jsdocs.io/package/@jupyterlab/notebook#NotebookModel.getMetadata