Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profdir with profiles.yml #52

Merged
merged 3 commits into from
May 30, 2023
Merged

Conversation

neo-andrew-moss
Copy link

Hi @mwhitaker

I am using your profdir branch in a ci. When providing a DBT_TOKEN, the sed command targets a datab.yml file. IMO this should be the standard profiles.yml file.

mwhitaker and others added 3 commits May 2, 2023 16:21
* bump to dbt version 1.4.6

* update set output command

* add documentation for base Dockerfile

---------

Co-authored-by: Leo Schick <leonhard.schick@gmail.com>
@mwhitaker
Copy link
Owner

Hi there,

Many thanks for this PR. I don't remember why I created the profdir branch, so am curious why you use that branch. Is there any feature in there that is different from the main/master branch?

Other than that I don't mind merging your PR since it's not an official branch.

@neo-andrew-moss
Copy link
Author

I use the profdir branch as the main branch of this action requires the profiles.yml file to exist alongside the dbt_project.yml file. In my project, I have the following setup:

├── .ci
│   ├── profiles.yml
├── .github
│   ├── workflows
│   │   ├── dbt_action.yml
├── packages
│   ├── dbt 
│   │   ├── dbt_project.yml
│   │   ├── models

This gives me and other developers a clear picture that we have a specific profiles.yml file for ci that is not to be used elsewhere.

The difference between main and profdir is that in profdir there is an additional input of dbt_profile_folder, which I specify as dbt_profile_folder: "../../.ci" to account for my project structure.

@mwhitaker mwhitaker merged commit 898f193 into mwhitaker:profdir May 30, 2023
@mwhitaker
Copy link
Owner

OK. I merged the PR.
For some reason, perhaps for testing specifically Databricks, I used a different profile yml, but I agree that it makes more sense to use profiles.yml.

Thanks for the PR!

Michael

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants