review

mvukov · Feb 3, 2024 · 73f0629 · 73f0629
1 parent 74371e6
commit 73f0629
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 6 deletions.
diff --git a/WORKSPACE b/WORKSPACE
@@ -1,8 +1,8 @@
 workspace(name = "com_github_mvukov_rules_ros2")
 
-load("//repositories:repositories.bzl", "ros2_repositories", "rules_ros2_workspace_deps")
+load("//repositories:repositories.bzl", "ros2_repositories", "ros2_workspace_repositories")
 
-rules_ros2_workspace_deps()
+ros2_workspace_repositories()
 
 ros2_repositories()
 

diff --git a/examples/WORKSPACE b/examples/WORKSPACE
@@ -16,9 +16,9 @@ local_repository(
 #     url = "https://github.com/mvukov/rules_ros2/archive/<git commit SHA>.tar.gz",
 # )
 
-load("@com_github_mvukov_rules_ros2//repositories:repositories.bzl", "ros2_repositories", "rules_ros2_workspace_deps")
+load("@com_github_mvukov_rules_ros2//repositories:repositories.bzl", "ros2_repositories", "ros2_workspace_repositories")
 
-rules_ros2_workspace_deps()
+ros2_workspace_repositories()
 
 ros2_repositories()
 

diff --git a/repositories/repositories.bzl b/repositories/repositories.bzl
@@ -8,8 +8,11 @@ load(
     "ros2_repositories_impl",
 )
 
-def rules_ros2_workspace_deps():
-    """Import http_archive dependencies for the WORKSPACE version of rules_ros2."""
+def ros2_workspace_repositories():
+    """Imports dependent third-party repositories for the non-blzmod (hence, workspace-) version of the repository.
+
+    In particular, imports third-party package repositories excluding ROS 2 packages. ROS 2-specific repositories are imported with `ros2_repositories()` macro.
+    """
     maybe(
         http_archive,
         name = "rules_python",