Expose weak versions of CAS methods #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Useful when using `spin` to implement higher-level sync primitives. Signed-off-by: Klim Tsoutsman <klim@tsoutsman.com>
zesterer
requested changes
Apr 12, 2023
Signed-off-by: Klim Tsoutsman <klim@tsoutsman.com>
Signed-off-by: Klim Tsoutsman <klim@tsoutsman.com>
|
Are you looking to see a new release with this feature? |
|
It would be nice but not critical. We're happy to just use a patch manifest section. |
|
Sorry, I'm currently implementing our blocking spin lock and noticed there isn't a way to access the reader count from the guard. Ideally, |
kevinaboos
pushed a commit
to theseus-os/Theseus
that referenced
this pull request
Apr 13, 2023
* Recent upstream changes exposed the `try_lock_weak()` function in `spin`'s `Mutex`, allowing us to use it in our implementation. * See <mvdnes/spin-rs#150> Signed-off-by: Klim Tsoutsman <klim@tsoutsman.com>
github-actions bot
pushed a commit
to theseus-os/Theseus
that referenced
this pull request
Apr 13, 2023
* Recent upstream changes exposed the `try_lock_weak()` function in `spin`'s `Mutex`, allowing us to use it in our implementation. * See <mvdnes/spin-rs#150> Signed-off-by: Klim Tsoutsman <klim@tsoutsman.com> 8e9638d
github-actions bot
pushed a commit
to tsoutsman/Theseus
that referenced
this pull request
Apr 14, 2023
…s-os#935) * Recent upstream changes exposed the `try_lock_weak()` function in `spin`'s `Mutex`, allowing us to use it in our implementation. * See <mvdnes/spin-rs#150> Signed-off-by: Klim Tsoutsman <klim@tsoutsman.com> 8e9638d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I'm working on implementing sync primitives in Theseus OS on top of spin locks. We currently have to implement our own spin lock that is identical to
spinexcept that it exposestry_lock_weak, so that we can have customlockimplementations that use a weak CMPXCHG, while still using a strong CMPXCHG fortry_lock.It would be nice if we could upstream this so that we could directly depend on
spin. I think it makes sense to include it asspinis often used to build higher-level primitives which could use a weak CMPXCHG for better performance.