Add an MSRV policy #131
Merged
Add an MSRV policy #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as I know, there is no official Minimum Safe Rust Version (MSRV) policy for this crate, which makes it difficult to include it in crates that do have an MSRV policy. After some testing and adjustment, I've found that the MSRV for this crate is 1.38.0. If you disable some features, it's probably lower, but I think a two-year old version of Rustc is conservative enough. This pull request adds an MSRV policy, as well as a test in the CI to make sure that the crate builds on the MSRV.