Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discord rich presence feature implementation #5

Merged
merged 5 commits into from
Jan 23, 2024

Conversation

waveyboym
Copy link
Member

Implementation of discord rich presence:

  1. I made use of the discord-rich-presence crate using version 0.2.3
  2. All of the code for the RPC API is found in discord_rpc which acts as an API wrapper and only exposes certain functions that will be needed by the frontend, namely:
allow_connection_and_connect_to_discord_rpc,
attempt_to_connect_if_possible, 
disallow_connection_and_close_discord_rpc,
set_discord_rpc_activity, 
clear_discord_rpc_activity
  1. The functionality of discord rpc has been tested and shows that it is stable and works well enough.
  2. A dotenv crate was also added to store the client_id for discord in dev environments without uploading it to github, however when a production build is made, the client_id can just be embedded in the source code if building with an env variable fails.

A production build is yet to be tested but will be tested before this pr is merged with main-app-dev

@waveyboym waveyboym added the enhancement New feature or request label Jan 19, 2024
@waveyboym waveyboym self-assigned this Jan 19, 2024
@waveyboym waveyboym marked this pull request as draft January 19, 2024 19:06
@waveyboym waveyboym added good first issue Good for newcomers backend-rust This pr involves backend rust code changes frontend-typescript This pr involves frontend typescript changes api changes This pr modifies backend exposed functions labels Jan 19, 2024
@waveyboym waveyboym marked this pull request as ready for review January 23, 2024 11:13
@waveyboym waveyboym merged commit 24b8e0f into main-app-dev Jan 23, 2024
@waveyboym waveyboym deleted the discord-rich-presence branch January 23, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api changes This pr modifies backend exposed functions backend-rust This pr involves backend rust code changes enhancement New feature or request frontend-typescript This pr involves frontend typescript changes good first issue Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant