Topic net responders #234
Merged
Topic net responders #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shall we do a new release? Yes we should!
Towards release together with upcoming tidal 1.7
Fix for gain / overgain
telephon
reviewed
Feb 27, 2021
telephon
reviewed
Feb 27, 2021
telephon
reviewed
Feb 28, 2021
| var controls = synth.controls; | ||
| var controlNames = msg[1]; | ||
| controls.do{|control| controlNames = controlNames ++ " " ++ control.name}; | ||
| tidalAddr.sendMsg("/dirt/synth-info/reply", controlNames); |
There was a problem hiding this comment.
One thing: don't you also want to send the default values over? Or is that not useful on the tidal side ...
There was a problem hiding this comment.
That might be useful for the human user to know. There could be more info, like the normal range of the parameter, whether it can be controlled via a bus and so on.. So maybe we should think a bit ahead and flesh out #199 a bit first.
(This PR came from a question on the forum)
There was a problem hiding this comment.
OK, I'm going over there …
|
Maybe it's OK to merge this as-is? |
ndr-brt
pushed a commit
to ndr-brt/SuperDirt
that referenced
this pull request
Jan 3, 2022
* reply to the tidal who most recently said hello * net responder to return information about a synth * clean up Co-authored-by: Julian Rohrhuber <rohrhuber@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.