Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jellyfin: Don't fail entire sync if a single track or album have an invalid mbid #1338

Merged
merged 2 commits into from
Jun 10, 2024

Conversation

Jc2k
Copy link
Contributor

@Jc2k Jc2k commented Jun 10, 2024

This is a follow up to #1332, and handles InvalidDataError in some other cases to ensure a Jellyfin sync does not fail entirely for a single bad file.

(I've not seen these ones in the wild, but there is the same lack of validation on the Jellyfin side so these seem worth adding).

Copy link
Member

@marcelveldt marcelveldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@marcelveldt marcelveldt merged commit c472f4c into music-assistant:main Jun 10, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants