Tanner develop fixes phase #2 #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 696
💛 - Coveralls |
afeena
reviewed
Jul 17, 2018
tanner/api/api.py
Outdated
| @@ -51,7 +51,7 @@ def __init__(self, redis_client): | |||
| if not query_res: | |||
| return 'Invalid SNARE UUID' | |||
| for (i, val) in enumerate(query_res): | |||
| query_res[i] = json.loads(val) | |||
| query_res[i] = json.loads(val.decode("utf-8")) | |||
There was a problem hiding this comment.
I'd better put encoding things into redis query
There was a problem hiding this comment.
zrevrangebyscore redis query doesn't have encoding parameter. So except for this case, I have added encoding things in the redis query itself. Please look into it.
There was a problem hiding this comment.
Actually it has this parameter (maybe they forgot to add it into the docs) :)
|
@afeena That redis encoding is fixed. Please look into it now :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fix the following: