Build fixes, throw out standalone CELT in the process #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It causes strange build failures for the Mumble iOS app, and seems to build fine for both Mac and iOS even without it.
This moves the oldest supported iPhone up from the 4s to the 5s, which I would say is pretty fair ;) This also means aarch64/arm64 is the only architecture we have to support going forward.
it's unused and we're running at least iOS 12 anyway
I was sometimes hitting the stubbed out CELT branch, which seemed like a race condition. In all these cases, _connection was nil. Calls on nil values are valid in Obj-C, and in this case will return NO. Check for a connection instead of just assuming there is one.
TODO: test with an old mumble server and maybe add some proper way to handle this for the MumbleKit consumer
|
Noting this because I realized I didn't mention it at all: CELT does not cause any problems when building just MumbleKit, as it is never linked into anything together with Opus yet. It only causes problems when trying to actually link MumbleKit to anything (like the iOS app) |
Krzmbrzl
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Got this to build for Mumble iOS with XCode 16.
For now I kept the deployment targets as low as possible without raising any obvious "unsupported" warnings.
This is by far not ideal (dependencies are wildly out of date, a bunch of deprecations persist) but at least it builds and is therefore usable for working on the actual Mumble app :)