GetGuardianData #98
Merged
GetGuardianData #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updated elrond-go + elrond-go-core to latest commit
AdoAdoAdo
requested changes
Sep 27, 2022
| @@ -3,8 +3,8 @@ module github.com/ElrondNetwork/elrond-sdk-erdgo | |||
| go 1.14 | |||
|
|
|||
| require ( | |||
| github.com/ElrondNetwork/elrond-go v1.3.38-0.20220901083346-925f26245a35 | |||
| github.com/ElrondNetwork/elrond-go-core v1.1.20-0.20220901061429-fc1143a4a107 | |||
| github.com/ElrondNetwork/elrond-go v1.3.38-0.20220912122303-9c2574322163 | |||
AdoAdoAdo
previously approved these changes
Sep 27, 2022
BeniaminDrasovean
requested changes
Oct 21, 2022
Comment on lines
+549
to
+554
| if check.IfNil(address) { | ||
| return nil, ErrNilAddress | ||
| } | ||
| if !address.IsValid() { | ||
| return nil, ErrInvalidAddress | ||
| } |
There was a problem hiding this comment.
Move this before L545. And add test for nil address.
There was a problem hiding this comment.
thanks, fixed GetAccount as well
…and GetGuardianData
AdoAdoAdo
approved these changes
Oct 21, 2022
BeniaminDrasovean
approved these changes
Oct 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.