MX-13883: native auth server use api for fetching the block #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| args.Proxy = &testsCommon.ProxyStub{ | ||
| GetHyperBlockByHashCalled: func(ctx context.Context, hash string) (*data.HyperBlock, error) { | ||
| return nil, expectedErr | ||
| args.HttpClientWrapper = &testsCommon.HTTPClientWrapperStub{ |
There was a problem hiding this comment.
should also update test name
authentication/native/server.go
Outdated
|
|
||
| func (server *authServer) getBlockByHash(ctx context.Context, hash string) (*data.Block, error) { | ||
| var block data.Block | ||
| buff, code, err := server.httpClientWrapper.GetHTTP(ctx, server.apiNetworkAddress+"/blocks/"+hash) |
There was a problem hiding this comment.
extract "/blocks/" in a constant then the full path concatenation in a local var
AdoAdoAdo
reviewed
Feb 20, 2023
| @@ -0,0 +1,23 @@ | |||
| package data | |||
|
|
|||
| type Block struct { | |||
There was a problem hiding this comment.
I think we can define only the used fields by the native auth.
I think timestamp is the only one we need? as the hash we already give on the API call and we don't check it again.
| @@ -0,0 +1,23 @@ | |||
| package data | |||
|
|
|||
| type Block struct { | |||
There was a problem hiding this comment.
missing comment on exported
authentication/native/server.go
Outdated
| pubKeyConverter core.PubkeyConverter | ||
| getTimeHandler func() time.Time | ||
| httpClientWrapper authentication.HttpClientWrapper | ||
| apiNetworkAddress string |
sstanculeanu
approved these changes
Feb 20, 2023
AdoAdoAdo
approved these changes
Feb 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.