Rebranding #120
Merged
Rebranding #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miiu96
reviewed
Jan 26, 2023
disabled/elrondShardCoordinator.go
Outdated
| @@ -1,35 +1,35 @@ | |||
| package disabled | |||
|
|
|||
| // ElrondShardCoordinator is the disabled shard coordinator instance that satisfies the elrond.sharding.Coordinator interface | |||
| type ElrondShardCoordinator struct { | |||
| // MultiversXShardCoordinator is the disabled shard coordinator instance that satisfies the mx-chain-go.sharding.Coordinator interface | |||
There was a problem hiding this comment.
maybe it can be renamed in ShardCoordinator
| logger "github.com/ElrondNetwork/elrond-go-logger" | ||
| "github.com/ElrondNetwork/elrond-sdk-erdgo/core" | ||
| "github.com/ElrondNetwork/elrond-sdk-erdgo/data" | ||
| "github.com/multiversx/mx-chain-core-go/core/check" |
There was a problem hiding this comment.
you should rename also the file.
blockchain/elrondBaseProxy.go
Outdated
| expirationTime time.Duration | ||
| httpClientWrapper httpClientWrapper | ||
| endpointProvider EndpointProvider | ||
| } | ||
|
|
||
| type elrondBaseProxy struct { | ||
| type multiversXBaseProxy struct { |
There was a problem hiding this comment.
maybe this structure can be named baseProxy without multiversX prefix
aggregator/notifees/elrondNotifee.go
Outdated
| // transaction, having the transaction's data field containing all the price changes information | ||
| func (en *elrondNotifee) PriceChanged(ctx context.Context, priceChanges []*aggregator.ArgsPriceChanged) error { | ||
| func (en *multiversXNotifee) PriceChanged(ctx context.Context, priceChanges []*aggregator.ArgsPriceChanged) error { |
There was a problem hiding this comment.
perhaps mxNotifee as it is shorter?
| @@ -27,8 +27,8 @@ var ( | |||
| keyGen = signing.NewKeyGenerator(suite) | |||
| ) | |||
|
|
|||
| func createMockArgsElrondNotifee() ArgsElrondNotifee { | |||
| return ArgsElrondNotifee{ | |||
| func createMockArgsMultiversXNotifee() ArgsMultiversXNotifee { | |||
There was a problem hiding this comment.
ArgsMxNotifee, also the constructor?
blockchain/proxy.go
Outdated
| // ArgsElrondProxy is the DTO used in the elrond proxy constructor | ||
| type ArgsElrondProxy struct { | ||
| // ArgsMultiversXProxy is the DTO used in the multiversx proxy constructor | ||
| type ArgsMultiversXProxy struct { |
There was a problem hiding this comment.
remove MultiversX ?
This file and the test file.
iulianpascalau
approved these changes
Jan 26, 2023
miiu96
approved these changes
Jan 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rebranding + mx-chain-go v1.4.4