Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix get non fungible tokens list #6647

Merged
merged 5 commits into from
Dec 5, 2024

Conversation

ssd04
Copy link
Contributor

@ssd04 ssd04 commented Dec 3, 2024

Reasoning behind the pull request

  • Add custom handling for NonFungibleESDT and NonFungibleESDTv2

Testing procedure

  • Standard system test
  • Observer and Proxy testing for "/network/esdt/non-fungible-tokens" endpoint - it should list all non fungible tokens

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

@ssd04 ssd04 self-assigned this Dec 3, 2024
Copy link

github-actions bot commented Dec 3, 2024

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

  • mx-chain-go Commit Hash: 8a9b204884f8e7ca93348ec453caba4be2b5ac2e
  • Current Branch: fix-api-nfts-tokens-type
  • mx-chain-go Target Branch: master
  • mx-chain-simulator-go Target Branch: main
  • mx-chain-testing-suite Target Branch: main

🚀 Environment Variables:

  • TIMESTAMP: 03122024-114336
  • PYTEST_EXIT_CODE: 0
    🎉 MultiversX CI/CD Workflow Complete!

@ssd04 ssd04 marked this pull request as ready for review December 3, 2024 12:20
bogdan-rosianu
bogdan-rosianu previously approved these changes Dec 3, 2024
Copy link

github-actions bot commented Dec 3, 2024

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

  • mx-chain-go Commit Hash: 58179fa5691523c7bfc4b6d903d315f9a7097982
  • Current Branch: fix-api-nfts-tokens-type
  • mx-chain-go Target Branch: master
  • mx-chain-simulator-go Target Branch: main
  • mx-chain-testing-suite Target Branch: main

🚀 Environment Variables:

  • TIMESTAMP: 03122024-123240
  • PYTEST_EXIT_CODE: 0
    🎉 MultiversX CI/CD Workflow Complete!

miiu96
miiu96 previously approved these changes Dec 3, 2024
Copy link
Contributor

@BeniaminDrasovean BeniaminDrasovean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it ok to merge this directly into master?

@ssd04
Copy link
Contributor Author

ssd04 commented Dec 3, 2024

Is it ok to merge this directly into master?

directed it to master for now, will see exactly where we'll merge it

Copy link

github-actions bot commented Dec 4, 2024

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

  • mx-chain-go Commit Hash: cfa93382fb91a15e1dc603403696d0f2a0c0c7df
  • Current Branch: fix-api-nfts-tokens-type
  • mx-chain-go Target Branch: master
  • mx-chain-simulator-go Target Branch: main
  • mx-chain-testing-suite Target Branch: main

🚀 Environment Variables:

  • TIMESTAMP: 04122024-102229
  • PYTEST_EXIT_CODE: 0
    🎉 MultiversX CI/CD Workflow Complete!

@ssd04 ssd04 changed the base branch from master to rc/spica-patch-mempool December 4, 2024 10:30
Copy link

github-actions bot commented Dec 4, 2024

⚠️ No report was generated due to an error or cancellation of the process.
Please checkout gh action logs for details

@sstanculeanu
Copy link
Collaborator

Run Tests:
mx-chain-simulator-go: main
mx-chain-testing-suite: main

Copy link

github-actions bot commented Dec 4, 2024

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

  • mx-chain-go Commit Hash: 4c24359ab89654bee5b184d2506d31cd959165bf
  • Current Branch: master
  • mx-chain-go Target Branch: ``
  • mx-chain-simulator-go Target Branch: main
  • mx-chain-testing-suite Target Branch: main

🚀 Environment Variables:

  • TIMESTAMP: 04122024-104635
  • PYTEST_EXIT_CODE: 0
    🎉 MultiversX CI/CD Workflow Complete!

Copy link

github-actions bot commented Dec 4, 2024

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

  • mx-chain-go Commit Hash: 4b2d82e05ad184256be29172643bba3f491b8286
  • Current Branch: fix-api-nfts-tokens-type
  • mx-chain-go Target Branch: rc/spica-patch-mempool
  • mx-chain-simulator-go Target Branch: main
  • mx-chain-testing-suite Target Branch: main

🚀 Environment Variables:

  • TIMESTAMP: 04122024-104652
  • PYTEST_EXIT_CODE: 0
    🎉 MultiversX CI/CD Workflow Complete!

@andreibancioiu
Copy link
Collaborator

System tests passed ✔️

@multiversx multiversx deleted a comment from github-actions bot Dec 5, 2024
@sstanculeanu
Copy link
Collaborator

Run Tests:
mx-chain-simulator-go: main
mx-chain-testing-suite: main

Copy link

github-actions bot commented Dec 5, 2024

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

  • mx-chain-go Commit Hash: 4c24359ab89654bee5b184d2506d31cd959165bf
  • Current Branch: master
  • mx-chain-go Target Branch: ``
  • mx-chain-simulator-go Target Branch: main
  • mx-chain-testing-suite Target Branch: main

🚀 Environment Variables:

  • TIMESTAMP: 05122024-102701
  • PYTEST_EXIT_CODE: 0
    🎉 MultiversX CI/CD Workflow Complete!

Copy link

github-actions bot commented Dec 5, 2024

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

  • mx-chain-go Commit Hash: 04fd98d273ce7f921db755558c05a887658a0443
  • Current Branch: fix-api-nfts-tokens-type
  • mx-chain-go Target Branch: rc/spica-patch-mempool
  • mx-chain-simulator-go Target Branch: main
  • mx-chain-testing-suite Target Branch: main

🚀 Environment Variables:

  • TIMESTAMP: 05122024-102816
  • PYTEST_EXIT_CODE: 0
    🎉 MultiversX CI/CD Workflow Complete!

@sstanculeanu sstanculeanu merged commit e65a3d4 into rc/spica-patch-mempool Dec 5, 2024
8 checks passed
@sstanculeanu sstanculeanu deleted the fix-api-nfts-tokens-type branch December 5, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants