Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't notify cache about nonces; pass the account nonce provider, instead #6603

Merged
merged 47 commits into from
Nov 27, 2024
Merged
Changes from 1 commit
Commits
Show all changes
47 commits
Select commit Hold shift + click to select a range
6841919
calculate hash only on log trace level set.
cristure Jul 26, 2024
85d93ac
add non-memory thrasher test.
cristure Jul 29, 2024
79eb08c
Merge branch 'rc/v1.7.next1' into benchmark_trie
AdoAdoAdo Sep 3, 2024
1ec7c5c
Merge branch 'rc/v1.7.next1' into benchmark_trie
andreibancioiu Sep 6, 2024
af01f4a
Convert artificial test into a benchmark.
andreibancioiu Sep 6, 2024
febe899
No more ForgetAllAccountNonces().
andreibancioiu Nov 13, 2024
535d51b
Remove NotifyAccountNonce().
andreibancioiu Nov 13, 2024
bca90d9
Properly invoke NewTxCache().
andreibancioiu Nov 13, 2024
278acf9
Reference new storage-go.
andreibancioiu Nov 13, 2024
f533a2b
Fix long test.
andreibancioiu Nov 14, 2024
4b8fb0a
Newer storage-go.
andreibancioiu Nov 14, 2024
a98f0a4
Merge branch 'selection-by-ppu' into MX-16107-no-more-notify
andreibancioiu Nov 14, 2024
0cb7187
Sketch CS test: TestMempoolWithChainSimulator_Eviction.
andreibancioiu Nov 14, 2024
bc70dcc
Merge branch 'rc/v1.7.next1' into benchmark_trie
andreibancioiu Nov 14, 2024
6a80857
Merge pull request #6338 from multiversx/benchmark_trie
andreibancioiu Nov 14, 2024
c4f2db5
Optimize GetExistingAccount(). Only encode address if log level is TR…
andreibancioiu Nov 14, 2024
1cb7594
Merge branch 'MX-16107-no-more-notify' of ssh://github.com/multiversx…
andreibancioiu Nov 14, 2024
26ddc02
Pass account nonce provider (backed by the accounts adapter) to Selec…
andreibancioiu Nov 15, 2024
38aeb55
Optimized logging. Don't directly encode to hex before calling log.Tr…
andreibancioiu Nov 15, 2024
297e530
Remove logic around "accountTxsShards" (was only needed for mempool n…
andreibancioiu Nov 15, 2024
e1d4287
Remove code not needed anymore.
andreibancioiu Nov 15, 2024
f84a3c6
Minor refactoring around nonce account provider.
andreibancioiu Nov 15, 2024
9aec5b9
Sketch additional CS tests (WIP).
andreibancioiu Nov 15, 2024
5b937db
AccountNonceProvider becomes AccountStateProvider (more information f…
andreibancioiu Nov 18, 2024
7fa9a6c
Merge branch 'selection-by-ppu' into MX-16107-no-more-notify
andreibancioiu Nov 18, 2024
7741b4e
Fix tests, reference newer storage.
andreibancioiu Nov 18, 2024
da36969
Fix long test.
andreibancioiu Nov 19, 2024
377cca5
Optimizations. Fix after self-review.
andreibancioiu Nov 19, 2024
5bb1b40
Fix old concurrency issue.
andreibancioiu Nov 19, 2024
0d295b8
Fix linter issues.
andreibancioiu Nov 19, 2024
f87f1c3
Remove unused field.
andreibancioiu Nov 19, 2024
4834372
Sketch a simulator for transactions selection - called in CreateBlock…
andreibancioiu Nov 19, 2024
9ff7f5c
Feed guardian checker into process/block/preprocess/transactions.
andreibancioiu Nov 19, 2024
0b5c262
Enhance accountStateProvider - make it know about guardians.
andreibancioiu Nov 19, 2024
cf4f1a8
Reference newer storage-go.
andreibancioiu Nov 20, 2024
1faa7f1
Fix tests.
andreibancioiu Nov 20, 2024
5b00521
Newer storage go. Additional tracing.
andreibancioiu Nov 20, 2024
7953116
Merge branch 'feat/mempool' into MX-16107-no-more-notify
andreibancioiu Nov 20, 2024
e1cb834
Fix tests.
andreibancioiu Nov 20, 2024
eca8029
Reference new storage-go.
andreibancioiu Nov 21, 2024
9005e76
Fix tests, fix after self-review.
andreibancioiu Nov 21, 2024
cfd1ea8
Remove chain simulator test (since it's not polished). Will be added …
andreibancioiu Nov 21, 2024
e02d607
In "interceptedHeader", handle concurrent access.
andreibancioiu Nov 22, 2024
2d52815
Handle non-executable transactions related to guardians in a separate…
andreibancioiu Nov 24, 2024
2a160f3
Fix linter issues.
andreibancioiu Nov 25, 2024
47159a5
(final) fix after self-review.
andreibancioiu Nov 25, 2024
25b2594
Fix after review.
andreibancioiu Nov 26, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Optimize GetExistingAccount(). Only encode address if log level is TR…
…ACE.
  • Loading branch information
andreibancioiu committed Nov 14, 2024
commit c4f2db5b2d2084d47a84c5c51adfadcfa92bb411
6 changes: 3 additions & 3 deletions state/accountsDB.go
Original file line number Diff line number Diff line change
@@ -653,9 +653,9 @@ func (adb *AccountsDB) GetExistingAccount(address []byte) (vmcommon.AccountHandl
return nil, fmt.Errorf("%w in GetExistingAccount", ErrNilAddress)
}

log.Trace("accountsDB.GetExistingAccount",
"address", hex.EncodeToString(address),
)
if log.GetLevel() == logger.LogTrace {
log.Trace("accountsDB.GetExistingAccount", "address", hex.EncodeToString(address))
}

mainTrie := adb.getMainTrie()
acnt, err := adb.getAccount(address, mainTrie)