Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend delegation log events #6292

Merged
merged 6 commits into from
Jul 12, 2024
Merged

Conversation

miiu96
Copy link
Contributor

@miiu96 miiu96 commented Jul 3, 2024

Reasoning behind the pull request

  • Fixed log events that are generated in multi claim and multi redelegate rewards operations from the delegation manager

Proposed changes

Testing procedure

  • Check the generated logs for claimRewards and delegate contains on last topic the address of the contract

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

@miiu96 miiu96 changed the base branch from master to rc/v1.7.next1 July 3, 2024 10:56
@miiu96 miiu96 self-assigned this Jul 3, 2024
Copy link

codecov bot commented Jul 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.79%. Comparing base (654852c) to head (6f00bb3).
Report is 56 commits behind head on rc/v1.7.next1.

Additional details and impacted files
@@                Coverage Diff                @@
##           rc/v1.7.next1    #6292      +/-   ##
=================================================
- Coverage          78.79%   78.79%   -0.01%     
=================================================
  Files                753      753              
  Lines              98848    98906      +58     
=================================================
+ Hits               77886    77930      +44     
- Misses             15719    15726       +7     
- Partials            5243     5250       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@gabi-vuls gabi-vuls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normal allin test: v1.7.13-dev-config-aebb55e8e0 -> extend-delegation-log-even-96fb9cf9d7

--- Specific errors ---

block hash does not match 1607
wrong nonce in block 710
miniblocks does not match 0
num miniblocks does not match 0
miniblock hash does not match 0
block bodies does not match 1
receipts hash missmatch 0

/------/

--- Statistics ---

Nr. of all ERRORS: 17
Nr. of all WARNS: 673
Nr. of new ERRORS: 17
Nr. of new WARNS: 58
Nr. of PANICS: 0

/------/

@miiu96 miiu96 merged commit 48212f9 into rc/v1.7.next1 Jul 12, 2024
8 checks passed
@miiu96 miiu96 deleted the extend-delegation-log-events branch July 12, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants