-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend delegation log events #6292
Conversation
…ents # Conflicts: # go.mod # go.sum
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## rc/v1.7.next1 #6292 +/- ##
=================================================
- Coverage 78.79% 78.79% -0.01%
=================================================
Files 753 753
Lines 98848 98906 +58
=================================================
+ Hits 77886 77930 +44
- Misses 15719 15726 +7
- Partials 5243 5250 +7 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Normal allin test: v1.7.13-dev-config-aebb55e8e0 -> extend-delegation-log-even-96fb9cf9d7
--- Specific errors ---
block hash does not match 1607
wrong nonce in block 710
miniblocks does not match 0
num miniblocks does not match 0
miniblock hash does not match 0
block bodies does not match 1
receipts hash missmatch 0
/------/
--- Statistics ---
Nr. of all ERRORS: 17
Nr. of all WARNS: 673
Nr. of new ERRORS: 17
Nr. of new WARNS: 58
Nr. of PANICS: 0
/------/
Reasoning behind the pull request
Proposed changes
claimRewards
andreDelegateRewards
delegation contract address
Testing procedure
claimRewards
anddelegate
contains on last topic the address of the contractPre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
feat
branch created?feat
branch merging, do all satellite projects have a proper tag insidego.mod
?