Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ChainSimulator: verify tx on send #6268

Merged
merged 1 commit into from
Jun 19, 2024
Merged

ChainSimulator: verify tx on send #6268

merged 1 commit into from
Jun 19, 2024

Conversation

sstanculeanu
Copy link
Collaborator

Reasoning behind the pull request

  • chain simulator used a disabled white list data verifier that returns true on IsWhitelisted method, thus the transactions sent through chain simulator would have never been checked

Proposed changes

  • use other implementation of disabled white list data verifier

Testing procedure

  • chain simulator only, no test needed

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

@sstanculeanu
updated processComponents of chainSimulator to use a disabledWhiteLis…
7817fca 
…tDataVerifier that returns false on IsWhitelisted
@sstanculeanu sstanculeanu self-assigned this Jun 19, 2024
@sstanculeanu sstanculeanu merged commit 609df2b into rc/v1.7.next1 Jun 19, 2024
8 checks passed
@sstanculeanu sstanculeanu deleted the chain_simulator_verify_tx branch June 19, 2024 13:24
@ssd04 ssd04 mentioned this pull request Jun 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miiu96 miiu96 miiu96 approved these changes

@BeniaminDrasovean BeniaminDrasovean BeniaminDrasovean approved these changes

@ssd04 ssd04 ssd04 approved these changes

Assignees

@sstanculeanu sstanculeanu

Labels
area:testing complexity:trivial impact:low size:small type:bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sstanculeanu @ssd04 @BeniaminDrasovean @miiu96