Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gasScheduleV8 #6267

Merged
merged 2 commits into from
Jun 20, 2024
Merged

gasScheduleV8 #6267

merged 2 commits into from
Jun 20, 2024

Conversation

sasurobert
Copy link
Contributor

Reasoning behind the pull request

Proposed changes

Testing procedure

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

Copy link
Contributor

@gabi-vuls gabi-vuls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normal allin test: 1.7.12-2a6916fbce -> gasScheduleV8-c487067338

--- Specific errors ---

block hash does not match 1931
wrong nonce in block 862
miniblocks does not match 0
num miniblocks does not match 0
miniblock hash does not match 0
block bodies does not match 1
receipts hash missmatch 0

/------/

--- Statistics ---

Nr. of all ERRORS: 10
Nr. of all WARNS: 5182
Nr. of new ERRORS: 10
Nr. of new WARNS: 1
Nr. of PANICS: 0

/------/

@sstanculeanu sstanculeanu merged commit 6947001 into master Jun 20, 2024
8 checks passed
@sstanculeanu sstanculeanu deleted the gasScheduleV8 branch June 20, 2024 11:17
@daorren
Copy link

daorren commented Jun 27, 2024

I noticed the code differences between gasScheduleV8 and gasScheduleV7 are in the [BaseOpsAPICost] section, so what does this influence specifically

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants