Fix genesis flags #5988
Fix genesis flags #5988
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## rc/v1.7.0 #5988 +/- ##
=============================================
- Coverage 80.30% 80.28% -0.03%
=============================================
Files 733 733
Lines 96250 96197 -53
=============================================
- Hits 77297 77235 -62
- Misses 13612 13617 +5
- Partials 5341 5345 +4 ☔ View full report in Codecov by Sentry. |
# Conflicts: # factory/processing/processComponents.go
| @@ -240,6 +240,7 @@ func NewProcessComponentsFactory(args ProcessComponentsFactoryArgs) (*processCom | |||
| txExecutionOrderHandler: args.TxExecutionOrderHandler, | |||
| genesisNonce: args.GenesisNonce, | |||
| genesisRound: args.GenesisRound, | |||
| roundConfig: args.RoundConfig, | |||
| @@ -42,6 +42,7 @@ type ArgsProcessComponentsHolder struct { | |||
| NodesCoordinator nodesCoordinator.NodesCoordinator | |||
|
|
|||
| EpochConfig config.EpochConfig | |||
| RoundConfig config.RoundConfig | |||
There was a problem hiding this comment.
can you remove from file
../configs/configs.go line 122 (configs.EpochConfig.EnableEpochs.StakingV2EnableEpoch = args.InitialEpoch + 1)
if the problem is fixed tests should pass without this line
There was a problem hiding this comment.
done, all tests pass without that line
There was a problem hiding this comment.
Normal allin test: v1.6.15-dev-config-eb2e06c06d -> fix-genesis-flags-333c4f2461
--- Specific errors ---
block hash does not match 2605
wrong nonce in block 1010
miniblocks does not match 0
num miniblocks does not match 0
miniblock hash does not match 0
block bodies does not match 0
receipts hash missmatch 0
/------/
--- Statistics ---
Nr. of all ERRORS: 9
Nr. of all WARNS: 9367
Nr. of new ERRORS: 9
Nr. of new WARNS: 81
Nr. of PANICS: 0
/------/
--- ERRORS ---
/------/
Reasoning behind the pull request
Proposed changes
Related Fix genesis flags mx-chain-core-go#288
Testing procedure
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?