Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new VM 1.5.27 #5936

Merged
merged 6 commits into from
Feb 15, 2024
Merged

new VM 1.5.27 #5936

merged 6 commits into from
Feb 15, 2024

Conversation

sasurobert
Copy link
Contributor

Reasoning behind the pull request

Proposed changes

Testing procedure

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

Copy link

codecov bot commented Feb 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b5dcb4f) 80.17% compared to head (f79b2d4) 80.17%.

Additional details and impacted files
@@              Coverage Diff               @@
##           rc/v1.6.next1    #5936   +/-   ##
==============================================
  Coverage          80.17%   80.17%           
==============================================
  Files                708      708           
  Lines              94124    94124           
==============================================
+ Hits               75462    75467    +5     
+ Misses             13316    13312    -4     
+ Partials            5346     5345    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iulianpascalau iulianpascalau changed the base branch from master to rc/v1.6.next1 February 12, 2024 07:06
go.mod Outdated
@@ -22,7 +22,7 @@ require (
github.com/multiversx/mx-chain-scenario-go v1.3.0
github.com/multiversx/mx-chain-storage-go v1.0.14
github.com/multiversx/mx-chain-vm-common-go v1.5.11
github.com/multiversx/mx-chain-vm-go v1.5.26
github.com/multiversx/mx-chain-vm-go v1.5.27-0.20240206121310-ce5f10e5fe16
github.com/multiversx/mx-chain-vm-v1_2-go v1.2.65
github.com/multiversx/mx-chain-vm-v1_3-go v1.3.66
github.com/multiversx/mx-chain-vm-v1_4-go v1.4.94
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please set this to v1.4.95

go.mod Outdated
@@ -22,7 +22,7 @@ require (
github.com/multiversx/mx-chain-scenario-go v1.3.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please set this to v1.4.2

gabi-vuls
gabi-vuls previously approved these changes Feb 15, 2024
Copy link
Contributor

@gabi-vuls gabi-vuls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • allin ✅
  • scenario ✅

Normal allin test: v1.6.13-dev-config-06f147d698 -> vm1.5.27-deduplicate-logs-680321cd7e

--- Specific errors ---

block hash does not match 6811
wrong nonce in block 2880
miniblocks does not match 0
num miniblocks does not match 0
miniblock hash does not match 0
block bodies does not match 0
receipts hash missmatch 0

/------/

--- Statistics ---

Nr. of all ERRORS: 1
Nr. of all WARNS: 357
Nr. of new ERRORS: 1
Nr. of new WARNS: 1
Nr. of PANICS: 0

/------/

--- ERRORS ---

/------/

iulianpascalau
iulianpascalau previously approved these changes Feb 15, 2024
andreibancioiu
andreibancioiu previously approved these changes Feb 15, 2024
Copy link
Collaborator

@andreibancioiu andreibancioiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

☑️

@gabi-vuls gabi-vuls merged commit 91079ba into rc/v1.6.next1 Feb 15, 2024
8 checks passed
@gabi-vuls gabi-vuls deleted the vm1.5.27-deduplicate-logs branch February 15, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants