-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed return value in the MaxGasPriceSetGuardian
method on the disabled fee handler
#5703
Conversation
…isabled fee handler
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5703 +/- ##
==========================================
+ Coverage 77.61% 77.65% +0.03%
==========================================
Files 656 656
Lines 86205 86205
==========================================
+ Hits 66908 66939 +31
+ Misses 14091 14059 -32
- Partials 5206 5207 +1 ☔ View full report in Codecov by Sentry. |
d4da4b9
@@ -49,7 +49,7 @@ func (fh *FeeHandler) ExtraGasLimitGuardedTx() uint64 { | |||
|
|||
// MaxGasPriceSetGuardian returns 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wrong comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will take care of that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Normal allin test: 1.5.14-0101225fc7 -> fix-disabled-fee-handler-d4da4b907a
--- Specific errors ---
block hash does not match 3835
wrong nonce in block 1586
miniblocks does not match 0
num miniblocks does not match 0
miniblock hash does not match 0
block bodies does not match 0
receipts hash missmatch 0
/------/
--- Statistics ---
Nr. of all ERRORS: 2
Nr. of all WARNS: 126
Nr. of new ERRORS: 2
Nr. of new WARNS: 32
Nr. of PANICS: 0
/------/
--- ERRORS ---
/------/
Reasoning behind the pull request
Proposed changes
MaxGasPriceSetGuardian
method for the disabled fee handlerTesting procedure
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
feat
branch created?feat
branch merging, do all satellite projects have a proper tag insidego.mod
?