Bootstrap components #5584
Bootstrap components #5584
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## feat/test-only-processor-node #5584 +/- ##
=================================================================
+ Coverage 79.93% 79.99% +0.05%
=================================================================
Files 718 719 +1
Lines 94505 94567 +62
=================================================================
+ Hits 75540 75645 +105
+ Misses 13574 13526 -48
- Partials 5391 5396 +5
☔ View full report in Codecov by Sentry. |
| "github.com/multiversx/mx-chain-go/sharding" | ||
| ) | ||
|
|
||
| type ArgsBootstrapComponentsHolder struct { |
| @@ -136,7 +137,7 @@ func CreateCoreComponentsHolder(args ArgsCoreComponentsHolder) (factory.CoreComp | |||
| instance.alarmScheduler = &mock.AlarmSchedulerStub{} | |||
| instance.syncTimer = &testscommon.SyncTimerStub{} | |||
| // TODO discuss with Iulian about the round handler | |||
There was a problem hiding this comment.
is TODO still valid?
There was a problem hiding this comment.
Yes, we need a custom component for the "rounderer"
| @@ -136,7 +137,7 @@ func CreateCoreComponentsHolder(args ArgsCoreComponentsHolder) (factory.CoreComp | |||
| instance.alarmScheduler = &mock.AlarmSchedulerStub{} | |||
| instance.syncTimer = &testscommon.SyncTimerStub{} | |||
| // TODO discuss with Iulian about the round handler | |||
There was a problem hiding this comment.
Yes, we need a custom component for the "rounderer"
| @@ -30,8 +31,12 @@ func createMockArgsTestOnlyProcessingNode(t *testing.T) ArgsTestOnlyProcessingNo | |||
| err = LoadConfigFromFile(pathForPrefsConfig, &prefsConfig) | |||
| assert.Nil(t, err) | |||
|
|
|||
| workingDir, err := os.Getwd() | |||
There was a problem hiding this comment.
we can remove this and use t.TempDir() instead
Reasoning behind the pull request
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?