Status Core Components and State Components #5573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## feat/test-only-processor-node #5573 +/- ##
=================================================================
- Coverage 79.98% 79.96% -0.03%
=================================================================
Files 713 716 +3
Lines 93997 94122 +125
=================================================================
+ Hits 75188 75267 +79
- Misses 13437 13470 +33
- Partials 5372 5385 +13
☔ View full report in Codecov by Sentry. |
… into state-core-and-state-components
| return nil, err | ||
| } | ||
|
|
||
| // TODO should call this |
There was a problem hiding this comment.
TODO still relevant?
| managedPeerMonitor common.ManagedPeersMonitor | ||
| } | ||
|
|
||
| func CreateStatusComponentsHolder(shardID uint32) (factory.StatusComponentsHolder, error) { |
There was a problem hiding this comment.
missing comments on all exported items in this file
|
|
||
| // ArgsStateComponents will hold the components needed for state components | ||
| type ArgsStateComponents struct { | ||
| Cfg config.Config |
There was a problem hiding this comment.
might rename to Config
| Core: args.CoreComponents, | ||
| StatusCore: args.StatusCore, | ||
| StorageService: args.StoreService, | ||
| ProcessingMode: 0, |
There was a problem hiding this comment.
might replace 0 with a constant
bogdan-rosianu
approved these changes
Sep 12, 2023
iulianpascalau
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasoning behind the pull request
StatusCoreComponentsStateComponentsStatusComponentsPre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?