Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed go build commands #5507

Merged
merged 1 commit into from
Aug 21, 2023
Merged

Fixed go build commands #5507

merged 1 commit into from
Aug 21, 2023

Conversation

iulianpascalau
Copy link
Contributor

Reasoning behind the pull request

  • fixed go build commands

Proposed changes

  • fixed go build commands

Testing procedure

  • not required, non-production changes were made

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

@iulianpascalau iulianpascalau added the ignore-for-release-notes Do not include item in release notes label Aug 21, 2023
@iulianpascalau iulianpascalau self-assigned this Aug 21, 2023
@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.04% ⚠️

Comparison is base (0a0bcee) 77.65% compared to head (a789211) 77.61%.

❗ Current head a789211 differs from pull request most recent head ef7cef3. Consider uploading reports for the commit ef7cef3 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5507      +/-   ##
==========================================
- Coverage   77.65%   77.61%   -0.04%     
==========================================
  Files         656      656              
  Lines       86205    86205              
==========================================
- Hits        66939    66906      -33     
- Misses      14059    14092      +33     
  Partials     5207     5207              

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iulianpascalau iulianpascalau merged commit 97aa59d into master Aug 21, 2023
@iulianpascalau iulianpascalau deleted the fix-go-build-commands branch August 21, 2023 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-for-release-notes Do not include item in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants